Issue 4174060: code review 4174060: 5l/6l/8l: use enums for header type and symbolic string...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4174060: code review 4174060: 5l/6l/8l: use enums for header type and symbolic string... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by brainman

Modified:
14 years ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

5l/6l/8l: use enums for header type and symbolic strings for -H option values Thanks to rsc for the suggestion.

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+248 lines, -187 lines)			Patch
M	src/cmd/5l/asm.c	View	1	5 chunks	+14 lines, -14 lines	0 comments	Download
M	src/cmd/5l/doc.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/5l/obj.c	View	1 2 3	9 chunks	+29 lines, -17 lines	0 comments	Download
M	src/cmd/6l/asm.c	View	1	16 chunks	+29 lines, -29 lines	0 comments	Download
M	src/cmd/6l/doc.go	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/cmd/6l/obj.c	View	1 2 3	10 chunks	+30 lines, -32 lines	0 comments	Download
M	src/cmd/6l/pass.c	View	1 2 3	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/cmd/8l/asm.c	View	1	18 chunks	+28 lines, -28 lines	0 comments	Download
M	src/cmd/8l/doc.go	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download
M	src/cmd/8l/obj.c	View	1 2 3	13 chunks	+42 lines, -47 lines	0 comments	Download
M	src/cmd/8l/pass.c	View	1 2 3	7 chunks	+8 lines, -8 lines	0 comments	Download
M	src/cmd/ld/data.c	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/cmd/ld/dwarf.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/ld/lib.h	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	src/cmd/ld/lib.c	View	1 2 3	1 chunk	+13 lines, -0 lines	0 comments	Download

Total messages: 7

brainman

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-02-21 05:54:23 UTC) #1

brainman

Russ, I will implement -Hwindowsgui option in a different CL. Alex

14 years ago (2011-02-21 05:58:00 UTC) #2

brainman

*** Submitted as http://code.google.com/p/go/source/detail?r=206a2622c6cb *** 5l/6l/8l: use enums for header type and symbolic strings for ...

14 years ago (2011-02-23 03:30:47 UTC) #6

On 2011/02/22 18:40:26, r wrote:
> LGTM

Thank you for review.