Issue 4173061: code review 4173061: json: only use alphanumeric tags

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4173061: code review 4173061: json: only use alphanumeric tags (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by rsc

Modified:
13 years, 2 months ago

Reviewers:

CC:
r, r2, golang-dev

Visibility:
Public.

Description

json: only use alphanumeric tags Almost the same definition as Go identifier names. (Leading digits are allowed.) Fixes issue 1520.

Patch Set 1 #

Patch Set 2 : diff -r 4dd2e19d227e https://go.googlecode.com/hg #

Patch Set 3 : diff -r 4dd2e19d227e https://go.googlecode.com/hg #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -9 lines)			Patch
M	src/pkg/json/decode.go	View	1	1 chunk	+8 lines, -6 lines	0 comments	Download
M	src/pkg/json/decode_test.go	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/pkg/json/encode.go	View	1	4 chunks	+17 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 2 months ago (2011-02-17 22:02:58 UTC) #1

LGTM we should probably think about making this package go faster one day

13 years, 2 months ago (2011-02-17 22:12:44 UTC) #2

rsc

13 years, 2 months ago (2011-02-17 22:14:26 UTC) #3

*** Submitted as 00102d48bc06 ***

json: only use alphanumeric tags

Almost the same definition as Go identifier names.
(Leading digits are allowed.)

Fixes issue 1520.

R=r, r2
CC=golang-dev
http://codereview.appspot.com/4173061

Expand All Messages | Collapse All Messages