Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1019)

Issue 4171043: code review 4171043: syscall: add sockaddr_dl, sysctl with routing message s... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by mikio
Modified:
14 years ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

syscall: add sockaddr_dl, sysctl with routing message support for darwin, freebsd

Patch Set 1 #

Patch Set 2 : diff -r 8280f07d4272 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8280f07d4272 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+958 lines, -113 lines) Patch
M src/pkg/syscall/mkerrors.sh View 1 2 chunks +17 lines, -6 lines 0 comments Download
M src/pkg/syscall/syscall_bsd.go View 1 3 chunks +53 lines, -1 line 0 comments Download
M src/pkg/syscall/syscall_darwin.go View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/pkg/syscall/syscall_freebsd.go View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/pkg/syscall/types_darwin.c View 1 6 chunks +28 lines, -5 lines 0 comments Download
M src/pkg/syscall/types_freebsd.c View 1 6 chunks +26 lines, -5 lines 0 comments Download
M src/pkg/syscall/zerrors_darwin_386.go View 1 3 chunks +82 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_darwin_amd64.go View 1 3 chunks +82 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_freebsd_386.go View 1 3 chunks +76 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_freebsd_amd64.go View 1 3 chunks +76 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_darwin_386.go View 1 3 chunks +118 lines, -17 lines 0 comments Download
M src/pkg/syscall/ztypes_darwin_amd64.go View 1 3 chunks +118 lines, -17 lines 0 comments Download
M src/pkg/syscall/ztypes_freebsd_386.go View 1 3 chunks +129 lines, -31 lines 0 comments Download
M src/pkg/syscall/ztypes_freebsd_amd64.go View 1 3 chunks +129 lines, -31 lines 0 comments Download

Messages

Total messages: 3
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years ago (2011-02-10 05:12:01 UTC) #1
rsc
LGTM
14 years ago (2011-02-11 19:33:32 UTC) #2
rsc
14 years ago (2011-02-11 19:34:01 UTC) #3
*** Submitted as 909045b05201 ***

syscall: add sockaddr_dl, sysctl with routing message support for darwin,
freebsd

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4171043

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b