Issue 4168059: code review 4168059: .hgignore: added *.cgo*.{c,go}

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4168059: code review 4168059: .hgignore: added .cgo.{c,go} (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by niemeyer

Modified:
13 years, 11 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

.hgignore: added *.cgo*.{c,go}

Patch Set 1 #

Patch Set 2 : diff -r fa0771258ae1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bc53bdb99fcf https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	.hgignore	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-02-21 04:11:27 UTC) #1

rsc

*** Submitted as a65868992d4e *** .hgignore: add *.cgo*.{c,go} R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/4168059 Committer: Russ Cox ...

14 years ago (2011-02-22 20:42:16 UTC) #3

rsc

Applied. > .hgignore: added *.cgo*.{c,go} please use imperative, not past tense, in descriptions. so s/added/add/ ...

14 years ago (2011-02-22 20:42:49 UTC) #4

niemeyer

14 years ago (2011-02-23 02:55:00 UTC) #5

> please use imperative, not past tense, in descriptions.
> so s/added/add/ (done during submit)

Ack.

Expand All Messages | Collapse All Messages