Issue 4167041: code review 4167041: runtime: fix memory allocation on 386

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4167041: code review 4167041: runtime: fix memory allocation on 386 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by rsc

Modified:
14 years, 1 month ago

Reviewers:

CC:
r, r2, golang-dev

Visibility:
Public.

Description

runtime: fix memory allocation on 386 BSD and Darwin require an extra page between end and the first mapping, and Windows has various memory in the way too. Fixes issue 1464.

Patch Set 1 #

Patch Set 2 : diff -r 770fc1179efc https://go.googlecode.com/hg #

Patch Set 3 : diff -r 770fc1179efc https://go.googlecode.com/hg #

Patch Set 4 : diff -r 770fc1179efc https://go.googlecode.com/hg #

Patch Set 5 : diff -r 770fc1179efc https://go.googlecode.com/hg #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	src/pkg/runtime/malloc.goc	View	1 2 3	1 chunk	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

14 years, 1 month ago (2011-02-09 19:51:52 UTC) #1

rsc

14 years, 1 month ago (2011-02-09 20:08:34 UTC) #3

*** Submitted as f05e2996c990 ***

runtime: fix memory allocation on 386

BSD and Darwin require an extra page between
end and the first mapping, and Windows has various
memory in the way too.

Fixes issue 1464.

R=r, r2
CC=golang-dev
http://codereview.appspot.com/4167041

Expand All Messages | Collapse All Messages