code review 41640043: runtime: fix crash in runtime.GoroutineProfile

runtime: fix crash in runtime.GoroutineProfile

This is a possible Go 1.2.1 candidate.

Fixes issue 6946.

[rsc, 2013-12-13 03:16:32]

Hello iant, r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2013-12-13 03:31:12]

LGTM

Bother.

Do we need to same thing in runtime·tracebackothers?  It looks fundamentally
similar to me if called from runtime.Stack.

[rsc, 2013-12-13 04:10:42]

Probably yes. I missed tracebackothers when I looked for other calls. I'll
think about whether we can change the API to make this easier.

[rsc, 2013-12-13 20:34:33]

Hello iant@golang.org, r@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[iant, 2013-12-13 20:44:17]

LGTM

[rsc, 2013-12-13 20:45:01]

*** Submitted as https://code.google.com/p/go/source/detail?r=e4c381446b48 ***

runtime: fix crash in runtime.GoroutineProfile

This is a possible Go 1.2.1 candidate.

Fixes issue 6946.

R=iant, r
CC=golang-dev
https://codereview.appspot.com/41640043

[gobot, 2013-12-18 05:46:47]

R=

[gobot, 2013-12-18 05:47:24]

This CL appears to have broken the TESTING builder.

[minux1, 2013-12-18 06:05:36]

On Wed, Dec 18, 2013 at 12:47 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the TESTING builder.

Aha, the new builder breakage notification is in the works. Great! Looking
forward to it.

[gobot, 2013-12-18 06:21:02]

This CL appears to have broken the linux-386 builder.