code review 4160049: code.html: update to reflect that package names need no...

code.html: update to reflect that package names need not be unique

Fixes issue 1507.

[r, 2011-02-12 20:00:50]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[eh, 2011-02-12 20:05:02]

On 12 February 2011 20:00,  <r@golang.org> wrote:
================================
> --- a/doc/code.html
> +++ b/doc/code.html
> @@ -160,9 +160,9 @@
>  Go's convention is that the package name is the last element of the
>  import path: the package imported as <code>"crypto/rot13"</code>
>  should be named <code>rot13</code>.

Don't goinstalled files rather trample on this convention?

Chris

-- 
Chris "allusive" Dollin

[rsc, 2011-02-13 02:02:04]

LGTM

[rsc, 2011-02-13 02:03:09]

>>  Go's convention is that the package name is the last element of the
>>  import path: the package imported as <code>"crypto/rot13"</code>
>>  should be named <code>rot13</code>.
>
> Don't goinstalled files rather trample on this convention?

Plenty of people have written packages that do not follow
this convention.  Those packages are just unconventional.
If you know of any, contact the others and ask them to fix them.

For an example of a conventional name using goinstall,
the package imported as "gosqlite.googlecode.com/hg/sqlite"
has package name sqlite.

Russ

[r, 2011-02-13 02:03:20]

*** Submitted as http://code.google.com/p/go/source/detail?r=bb62dc362308 ***

code.html: update to reflect that package names need not be unique

Fixes issue 1507.

R=golang-dev, ehog.hedge, rsc
CC=golang-dev
http://codereview.appspot.com/4160049

[eh, 2011-02-13 08:51:53]

On 13 February 2011 02:03, Russ Cox <rsc@golang.org> wrote:
>>>  Go's convention is that the package name is the last element of the
>>>  import path: the package imported as <code>"crypto/rot13"</code>
>>>  should be named <code>rot13</code>.
>>
>> Don't goinstalled files rather trample on this convention?
>
> Plenty of people have written packages that do not follow
> this convention.  Those packages are just unconventional.
> If you know of any, contact the others and ask them to fix them.

I see I've been mislead into taking mistakes as OK. Thanks for
the correction & ammunition, Russ.

Chris

-- 
Chris "allusive" Dollin