code review 41570047: cmd/gc: do not omit wrapper for expression (interface{....

cmd/gc: do not omit wrapper for expression (interface{...}).F

Fixes issue 6723.

[remyoudompheng, 2013-12-22 13:59:34]

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2014-01-07 01:50:37]

LGTM

I'm kind of skeptical this won't break anything, but if so it will be a weird
corner case and we'll have an opportunity to add a new test.

[remyoudompheng, 2014-01-07 12:27:17]

*** Submitted as https://code.google.com/p/go/source/detail?r=2ab78a00f2c9 ***

cmd/gc: do not omit wrapper for expression (interface{...}).F

Fixes issue 6723.

R=rsc
CC=golang-codereviews
https://codereview.appspot.com/41570047

[dave_cheney.net, 2014-01-07 13:22:14]

Hi Remy,

Could you please look at this build failure which is affecting most of the
builders

# ../test
# go run run.go -- fixedbugs/issue4590.go
exit status 1
6l: duplicate symbol go.interface { Hello(); Write() error }.Hello (types 1
and 1) in pkg2 and pkg2.6

Cheers

Dave


On Tue, Jan 7, 2014 at 11:27 PM, <remyoudompheng@gmail.com> wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=2ab78a00f2c9 ***
>
> cmd/gc: do not omit wrapper for expression (interface{...}).F
>
> Fixes issue 6723.
>
> R=rsc
> CC=golang-codereviews
> https://codereview.appspot.com/41570047
>
>
>
> https://codereview.appspot.com/41570047/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[remyoudompheng, 2014-01-07 13:36:32]

Hum, a file may have disappeared from the patch.

2014/1/7, Dave Cheney <dave@cheney.net>:
> Hi Remy,
>
> Could you please look at this build failure which is affecting most of the
> builders
>
> # ../test
> # go run run.go -- fixedbugs/issue4590.go
> exit status 1
> 6l: duplicate symbol go.interface { Hello(); Write() error }.Hello (types 1
> and 1) in pkg2 and pkg2.6
>
> Cheers
>
> Dave
>
>
> On Tue, Jan 7, 2014 at 11:27 PM, <remyoudompheng@gmail.com> wrote:
>
>> *** Submitted as
>> https://code.google.com/p/go/source/detail?r=2ab78a00f2c9 ***
>>
>> cmd/gc: do not omit wrapper for expression (interface{...}).F
>>
>> Fixes issue 6723.
>>
>> R=rsc
>> CC=golang-codereviews
>> https://codereview.appspot.com/41570047
>>
>>
>>
>> https://codereview.appspot.com/41570047/
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>

[remyoudompheng, 2014-01-07 15:07:02]

On 2014/01/07 13:22:14, dfc wrote:
> Hi Remy,
> 
> Could you please look at this build failure which is affecting most of the
> builders
> 
> # ../test
> # go run run.go -- fixedbugs/issue4590.go
> exit status 1
> 6l: duplicate symbol go.interface { Hello(); Write() error }.Hello (types 1
> and 1) in pkg2 and pkg2.6

Please see https://codereview.appspot.com/48420044