Issue 4130047: code review 4130047: crypto/x509: add name constraints support.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4130047: code review 4130047: crypto/x509: add name constraints support. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by agl1

Modified:
14 years, 1 month ago

Reviewers:

CC:
golang-dev, r, rsc

Visibility:
Public.

Description

crypto/x509: add name constraints support.

Patch Set 1 #

Patch Set 2 : diff -r b5d17ce5197c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b5d17ce5197c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r fd41b76c8e51 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r fd41b76c8e51 https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -3 lines)			Patch
	M	src/pkg/crypto/x509/x509.go	View	1 2	6 chunks	+73 lines, -2 lines	0 comments	Download
	M	src/pkg/crypto/x509/x509_test.go	View	1	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-02-05 15:50:20 UTC) #1

LGTM stylistically. it's simple enough that's probably enough, but if anyone x509-compliant wants to weigh ...

14 years, 1 month ago (2011-02-08 20:52:04 UTC) #2

agl1

14 years, 1 month ago (2011-02-09 13:39:49 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=23f6a8135930 ***

crypto/x509: add name constraints support.

R=golang-dev, r, rsc
CC=golang-dev
http://codereview.appspot.com/4130047

Expand All Messages | Collapse All Messages