Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 4127043: code review 4127043: template: Add simple formatter chaining. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by Kyle C
Modified:
14 years, 1 month ago
Reviewers:
CC:
r, rsc, r2, golang-dev
Visibility:
Public.

Description

template: Add simple formatter chaining. Fixes issue 676.

Patch Set 1 #

Patch Set 2 : code review 4127043: template: Add simple formatter chaining. #

Total comments: 14

Patch Set 3 : code review 4127043: template: Add simple formatter chaining. #

Total comments: 14

Patch Set 4 : diff -r 48ec378bff75 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 5 : diff -r a861348c835b https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 6 : diff -r a861348c835b https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 475e73445ae1 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r aa76041bc64d https://go.googlecode.com/hg/ #

Patch Set 9 : diff -r 0add71baf83a https://go.googlecode.com/hg/ #

Total comments: 6

Patch Set 10 : diff -r 0add71baf83a https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -80 lines) Patch
M src/pkg/template/template.go View 1 2 3 4 5 6 7 8 9 7 chunks +53 lines, -38 lines 0 comments Download
M src/pkg/template/template_test.go View 1 2 3 4 5 6 7 7 chunks +84 lines, -42 lines 0 comments Download

Messages

Total messages: 17
Kyle C
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 1 month ago (2011-01-31 20:49:34 UTC) #1
r
http://codereview.appspot.com/4127043/diff/2001/src/pkg/template/template.go File src/pkg/template/template.go (right): http://codereview.appspot.com/4127043/diff/2001/src/pkg/template/template.go#newcode65 src/pkg/template/template.go:65: the string representations of the fields. want to mention ...
14 years, 1 month ago (2011-01-31 21:33:20 UTC) #2
rsc
there should be a "fixes issue" in the CL description http://codereview.appspot.com/4127043/diff/2001/src/pkg/template/template.go File src/pkg/template/template.go (right): http://codereview.appspot.com/4127043/diff/2001/src/pkg/template/template.go#newcode71 ...
14 years, 1 month ago (2011-01-31 23:39:31 UTC) #3
Kyle C
http://codereview.appspot.com/4127043/diff/2001/src/pkg/template/template.go File src/pkg/template/template.go (right): http://codereview.appspot.com/4127043/diff/2001/src/pkg/template/template.go#newcode65 src/pkg/template/template.go:65: the string representations of the fields. On 2011/01/31 21:33:20, ...
14 years, 1 month ago (2011-02-01 00:42:15 UTC) #4
Kyle C
Hello r, rsc (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 1 month ago (2011-02-01 00:42:39 UTC) #5
r
http://codereview.appspot.com/4127043/diff/6002/src/pkg/template/template.go File src/pkg/template/template.go (right): http://codereview.appspot.com/4127043/diff/6002/src/pkg/template/template.go#newcode68 src/pkg/template/template.go:68: with the each formatter operating on the bytes generated ...
14 years, 1 month ago (2011-02-01 01:24:32 UTC) #6
Kyle C
PTAL. http://codereview.appspot.com/4127043/diff/6002/src/pkg/template/template.go File src/pkg/template/template.go (right): http://codereview.appspot.com/4127043/diff/6002/src/pkg/template/template.go#newcode68 src/pkg/template/template.go:68: with the each formatter operating on the bytes ...
14 years, 1 month ago (2011-02-03 17:21:28 UTC) #7
rsc
http://codereview.appspot.com/4127043/diff/12001/src/pkg/template/template.go File src/pkg/template/template.go (right): http://codereview.appspot.com/4127043/diff/12001/src/pkg/template/template.go#newcode728 src/pkg/template/template.go:728: var destbuf, prevbuf *bytes.Buffer These should be in the ...
14 years, 1 month ago (2011-02-03 18:07:47 UTC) #8
Kyle C
PTAL http://codereview.appspot.com/4127043/diff/12001/src/pkg/template/template.go File src/pkg/template/template.go (right): http://codereview.appspot.com/4127043/diff/12001/src/pkg/template/template.go#newcode728 src/pkg/template/template.go:728: var destbuf, prevbuf *bytes.Buffer Yeah. That's much better, ...
14 years, 1 month ago (2011-02-03 20:39:51 UTC) #9
r
looking good it would be fine to put the formatter tests into the main test ...
14 years, 1 month ago (2011-02-03 20:47:38 UTC) #10
Kyle C
I moved the formatter Tests in with the chained formatter tests and renamed the test ...
14 years, 1 month ago (2011-02-04 23:46:39 UTC) #11
r2
i just checked in a change to template. please sync, update, and upload. -rob
14 years, 1 month ago (2011-02-04 23:57:33 UTC) #12
Kyle C
Saw your change, synced, merged, and uploaded before sending my mail. I've hg upload once ...
14 years, 1 month ago (2011-02-05 00:08:01 UTC) #13
r
a couple of comment tweaks but it's looking good http://codereview.appspot.com/4127043/diff/4002/src/pkg/template/template.go File src/pkg/template/template.go (right): http://codereview.appspot.com/4127043/diff/4002/src/pkg/template/template.go#newcode75 src/pkg/template/template.go:75: ...
14 years, 1 month ago (2011-02-05 00:16:04 UTC) #14
Kyle C
http://codereview.appspot.com/4127043/diff/4002/src/pkg/template/template.go File src/pkg/template/template.go (right): http://codereview.appspot.com/4127043/diff/4002/src/pkg/template/template.go#newcode75 src/pkg/template/template.go:75: emitted by the one to its left. On 2011/02/05 ...
14 years, 1 month ago (2011-02-05 00:34:00 UTC) #15
r
LGTM
14 years, 1 month ago (2011-02-05 00:36:31 UTC) #16
r
14 years, 1 month ago (2011-02-05 00:37:34 UTC) #17
*** Submitted as http://code.google.com/p/go/source/detail?r=204118e30fbd ***

template: Add simple formatter chaining.

Fixes issue 676.

R=r, rsc, r2
CC=golang-dev
http://codereview.appspot.com/4127043

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b