Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(360)

Issue 4126053: code review 4126053: spec: allow imported packages named main (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by rsc
Modified:
13 years, 3 months ago
Reviewers:
CC:
gri, r, gri1, golang-dev
Visibility:
Public.

Description

spec: allow imported packages named main Prior to this CL, there were two requirements about the package name main. 1. The package that sits at the root of the import graph (the one where program execution begins) must be named main. 2. No other package in the program can be named main. This CL only removes requirement #2, which can be done without changing any other Go documentation. The new wording and formatting is such that removing requirement #1 can be done by deleting a single line, but making that change is explicitly outside the scope of this CL, because it would require changes to other documentation at the same time.

Patch Set 1 #

Patch Set 2 : diff -r 26ff781f396e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 26ff781f396e https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r e5af7083456c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 48ec378bff75 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M doc/go_spec.html View 1 2 3 3 chunks +13 lines, -17 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello gri, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 3 months ago (2011-02-02 23:49:31 UTC) #1
gri1
LGTM http://codereview.appspot.com/4126053/diff/4001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/4126053/diff/4001/doc/go_spec.html#newcode2 doc/go_spec.html:2: <!-- subtitle Version of February 1, 2011 --> ...
13 years, 3 months ago (2011-02-03 00:06:51 UTC) #2
r
LGTM
13 years, 3 months ago (2011-02-03 06:09:20 UTC) #3
rsc
13 years, 3 months ago (2011-02-03 18:40:58 UTC) #4
*** Submitted as e6f165514448 ***

spec: allow imported packages named main

Prior to this CL, there were two requirements about the
package name main.

1. The package that sits at the root of the import graph
   (the one where program execution begins)
   must be named main.

2. No other package in the program can be named main.

This CL only removes requirement #2, which can be done
without changing any other Go documentation.

The new wording and formatting is such that removing
requirement #1 can be done by deleting a single line,
but making that change is explicitly outside the scope
of this CL, because it would require changes to other
documentation at the same time.

R=gri, r, gri1
CC=golang-dev
http://codereview.appspot.com/4126053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b