Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3573)

Issue 41080043: code review 41080043: go.tools/types: skip "imported but not used" check if I... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by adonovan
Modified:
10 years, 4 months ago
Reviewers:
gri
CC:
gri, golang-dev
Visibility:
Public.

Description

go.tools/types: skip "imported but not used" check if IgnoreFuncBodies. Obviously in that mode, we can't correctly diagnose such errors, so we shouldn't attempt it (and emit false positives).

Patch Set 1 #

Patch Set 2 : diff -r de58424a6f88 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r de58424a6f88 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r de58424a6f88 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -24 lines) Patch
M go/types/resolver.go View 1 1 chunk +28 lines, -24 lines 0 comments Download

Messages

Total messages: 3
adonovan
Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
10 years, 4 months ago (2013-12-11 22:28:18 UTC) #1
gri
LGTM
10 years, 4 months ago (2013-12-11 22:30:59 UTC) #2
adonovan
10 years, 4 months ago (2013-12-12 02:12:10 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=000d539042f7&repo=tools ***

go.tools/types: skip "imported but not used" check if IgnoreFuncBodies.

Obviously in that mode, we can't correctly diagnose such
errors, so we shouldn't attempt it (and emit false positives).

R=gri
CC=golang-dev
https://codereview.appspot.com/41080043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b