Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 4092042: code review 4092042: codelab/wiki: fix freebsd build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by rsc
Modified:
14 years, 1 month ago
Reviewers:
r2
CC:
adg, golang-dev
Visibility:
Public.

Description

codelab/wiki: fix freebsd build

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M doc/codelab/wiki/Makefile View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 1 month ago (2011-01-26 18:02:08 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=363d4b0c4b20 *** codelab/wiki: fix freebsd build TBR=adg CC=golang-dev http://codereview.appspot.com/4092042
14 years, 1 month ago (2011-01-26 18:02:10 UTC) #2
r2
LGTM
14 years, 1 month ago (2011-01-26 18:09:02 UTC) #3
rsc
14 years, 1 month ago (2011-01-26 18:30:12 UTC) #4
adg -

this still doesn't fix all the builds:
freebsd/386 and maybe others don't have curl.
it would be nice not to depend on curl.
please replace with a program using http.Get.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b