Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(963)

Issue 4079041: code review 4079041: Implemented exception handling on Windows. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by hector
Modified:
13 years, 3 months ago
Reviewers:
CC:
rsc, brainman, golang-dev
Visibility:
Public.

Description

Implemented exception handling on Windows.

Patch Set 1 #

Patch Set 2 : code review 4079041: Implemented exception handling on Windows. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -41 lines) Patch
M .hgignore View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/8l/pass.c View 1 chunk +7 lines, -0 lines 0 comments Download
M src/cmd/godefs/main.c View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/godefs/stabs.c View 7 chunks +48 lines, -33 lines 1 comment Download
M src/pkg/runtime/proc.c View 4 chunks +14 lines, -2 lines 0 comments Download
M src/pkg/runtime/windows/386/defs.h View 1 chunk +61 lines, -0 lines 0 comments Download
M src/pkg/runtime/windows/386/rt0.s View 1 chunk +5 lines, -0 lines 0 comments Download
M src/pkg/runtime/windows/386/signal.c View 2 chunks +78 lines, -0 lines 0 comments Download
M src/pkg/runtime/windows/386/sys.s View 2 chunks +51 lines, -5 lines 0 comments Download
M src/pkg/runtime/windows/defs.c View 2 chunks +18 lines, -0 lines 0 comments Download
M src/pkg/runtime/windows/mem.c View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/runtime/windows/os.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/windows/thread.c View 2 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 4
hector
Hello rsc, brainman (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 3 months ago (2011-01-19 09:01:42 UTC) #1
rsc
LGTM Welcome back! http://codereview.appspot.com/4079041/diff/2001/src/cmd/godefs/stabs.c File src/cmd/godefs/stabs.c (right): http://codereview.appspot.com/4079041/diff/2001/src/cmd/godefs/stabs.c#newcode288 src/cmd/godefs/stabs.c:288: ++*pp; could just add case 'k' ...
13 years, 3 months ago (2011-01-19 20:05:44 UTC) #2
rsc
*** Submitted as b897d583e187 *** windows: implement exception handling R=rsc, brainman CC=golang-dev http://codereview.appspot.com/4079041 Committer: Russ ...
13 years, 3 months ago (2011-01-19 20:10:17 UTC) #3
hector
13 years, 3 months ago (2011-01-19 20:42:08 UTC) #4
Hi Russ,

It's nice to be back!

I decided to check up on Go after I found myself contemplating on a choice of
programming language for a new project idea that I have.  It took me the length
of the Christmas break to get back up to speed with the changes in Go, but it
wasn't too daunting given that I had already got my feet wet with the language
last year.  Just over a week ago I was perusing the Issues list and spotted the
one labelled ExpertNeeded, so I thought I would see how difficult it would be to
implement.  I even learnt an extra thing or two about Windows exception
handling.

Anyway, it's great to see the Go community continue to thrive, and thank you for
the prompt review and submission.

Thanks,
Hector
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b