Issue 4071041: code review 4071041: gc: delete float, complex

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4071041: code review 4071041: gc: delete float, complex (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by rsc

Modified:
14 years, 2 months ago

Reviewers:

CC:
ken2, golang-dev

Visibility:
Public.

gc: delete float, complex rename cmplx -> complex

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -56 lines)			Patch
M	src/cmd/5g/cgen.c	View	1 2 3	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/cmd/5g/galign.c	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/cmd/5g/reg.c	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/6g/galign.c	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/cmd/6g/reg.c	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/cmd/8g/cgen.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/8g/galign.c	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/cmd/8g/reg.c	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/gc/align.c	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/cmd/gc/const.c	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/cmd/gc/cplx.c	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/cmd/gc/go.h	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	src/cmd/gc/lex.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/print.c	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/gc/reflect.c	View	1 2	5 chunks	+0 lines, -7 lines	0 comments	Download
M	src/cmd/gc/sinit.c	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/cmd/gc/subr.c	View	1	4 chunks	+1 line, -7 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1	3 chunks	+2 lines, -5 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/ld/dwarf.c	View	1 2	3 chunks	+0 lines, -4 lines	0 comments	Download

Total messages: 2

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 2 months ago (2011-01-19 03:45:07 UTC) #1

rsc

14 years, 2 months ago (2011-01-20 04:08:13 UTC) #2

*** Submitted as 8041d740d1fe ***

gc: delete float, complex
rename cmplx -> complex

R=ken2
CC=golang-dev
http://codereview.appspot.com/4071041