code review 40600047: net: lookup protocol in lower-case on Plan 9

net: lookup protocol in lower-case on Plan 9

Protocol keywords are case-insensitive,
but the Ndb database is case-sensitive.

Also use the generic net protocol instead
of tcp in lookupHost.

[0intro, 2013-12-12 21:42:02]

Hello golang-dev (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-12-16 19:59:34]

LGTM



On Thu, Dec 12, 2013 at 1:42 PM, <0intro@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> net: lookup protocol in lower-case on Plan 9
>
> Protocol keywords are case-insensitive,
> but the Ndb database is case-sensitive.
>
> Please review this at https://codereview.appspot.com/40600047/
>
> Affected files (+2, -1 lines):
>   M src/pkg/net/lookup_plan9.go
>
>
> Index: src/pkg/net/lookup_plan9.go
> ===================================================================
> --- a/src/pkg/net/lookup_plan9.go
> +++ b/src/pkg/net/lookup_plan9.go
> @@ -7,6 +7,7 @@
>  import (
>         "errors"
>         "os"
> +       "strings"
>  )
>
>  func query(filename, query string, bufSize int) (res []string, err error)
> {
> @@ -72,7 +73,7 @@
>  // lookupProtocol looks up IP protocol name and returns
>  // the corresponding protocol number.
>  func lookupProtocol(name string) (proto int, err error) {
> -       lines, err := query("/net/cs", "!protocol="+name, 128)
> +       lines, err := query("/net/cs", "!protocol="+strings.ToLower(name),
> 128)
>         if err != nil {
>                 return 0, err
>         }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[bradfitz, 2013-12-16 20:00:25]

*** Submitted as https://code.google.com/p/go/source/detail?r=e0ea4d8a1a5f ***

net: lookup protocol in lower-case on Plan 9

Protocol keywords are case-insensitive,
but the Ndb database is case-sensitive.

Also use the generic net protocol instead
of tcp in lookupHost.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/40600047

Committer: Brad Fitzpatrick <bradfitz@golang.org>