Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(515)

Issue 4053042: code review 4053042: test: s/float/float64/ (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by iant
Modified:
14 years, 2 months ago
Reviewers:
CC:
adg, rsc, golang-dev
Visibility:
Public.

Description

test: s/float/float64/ Otherwise gccgo gives an extra error message not matched by errchk.

Patch Set 1 #

Patch Set 2 : code review 4053042: test: s/float/float64/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/method1.go View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
iant
Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 2 months ago (2011-01-21 16:25:52 UTC) #1
rsc
LGTM
14 years, 2 months ago (2011-01-21 16:36:07 UTC) #2
iant
14 years, 2 months ago (2011-01-21 16:38:07 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=677c74edcd26 ***

test: s/float/float64/

Otherwise gccgo gives an extra error message not matched by errchk.

R=adg, rsc
CC=golang-dev
http://codereview.appspot.com/4053042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b