Issue 4050042: code review 4050042: crypto/twofish: update with rsc's comments

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4050042: code review 4050042: crypto/twofish: update with rsc's comments (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by agl1

Modified:
13 years, 4 months ago

Reviewers:

CC:
rsc, berengar.lehr_gmx.de, golang-dev

Visibility:
Public.

Description

crypto/twofish: update with rsc's comments TBR=rsc

Patch Set 1 #

Patch Set 2 : code review 4050042: crypto/twofish: update with rsc's comments #

Patch Set 3 : code review 4050042: crypto/twofish: update with rsc's comments #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -67 lines)			Patch
	M	src/pkg/crypto/twofish/twofish.go	View		10 chunks	+65 lines, -65 lines	0 comments	Download
	M	src/pkg/crypto/twofish/twofish_test.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

agl1

Hello rsc (cc: berengar.lehr@gmx.de, golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 4 months ago (2011-01-20 00:34:11 UTC) #1

agl1

13 years, 4 months ago (2011-01-20 00:41:53 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=d1d939ce68ea ***

	crypto/twofish: update with rsc's comments

        TBR=rsc

R=rsc
CC=berengar.lehr, golang-dev
http://codereview.appspot.com/4050042

Expand All Messages | Collapse All Messages