code review 4031041: runtime/debug: new package

runtime/debug: new package
Facilities for printing stack traces from within a running goroutine.

[r, 2011-01-14 20:37:34]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2011-01-14 20:37:57]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2011-01-15 22:43:48]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-01-18 20:05:04]

http://codereview.appspot.com/4031041/diff/16001/src/pkg/runtime/debug/stack.go
File src/pkg/runtime/debug/stack.go (right):

http://codereview.appspot.com/4031041/diff/16001/src/pkg/runtime/debug/stack....
src/pkg/runtime/debug/stack.go:24: unicodeChar = "\u00A0-\U0010FFFF"
You can probably avoid the regexp stuff by using runtime.FuncForPC.

http://codereview.appspot.com/4031041/diff/16001/src/pkg/runtime/debug/stack....
src/pkg/runtime/debug/stack.go:40: // PrintStack prints to standard error the
stack trace returned by Stack().
s/()//

http://codereview.appspot.com/4031041/diff/16001/src/pkg/runtime/debug/stack....
src/pkg/runtime/debug/stack.go:45: // Stack() returns a representation of the
stack trace of the goroutine that calls it.
s/representation of the/formatted/

http://codereview.appspot.com/4031041/diff/16001/src/pkg/runtime/debug/stack....
src/pkg/runtime/debug/stack.go:46: // For each routine, it prints the source
line information and PC value, then
s/prints/includes/

[r, 2011-01-18 21:25:06]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-01-19 18:31:42]

LGTM

http://codereview.appspot.com/4031041/diff/23001/src/pkg/runtime/debug/stack.go
File src/pkg/runtime/debug/stack.go (right):

http://codereview.appspot.com/4031041/diff/23001/src/pkg/runtime/debug/stack....
src/pkg/runtime/debug/stack.go:28: // Stack() returns a formatted stack trace of
the goroutine that calls it.
s/()//

http://codereview.appspot.com/4031041/diff/23001/src/pkg/runtime/debug/stack....
src/pkg/runtime/debug/stack.go:36: // stack implements Stack(), skipping 2
frames
s/()//

[r, 2011-01-19 20:28:41]

*** Submitted as http://code.google.com/p/go/source/detail?r=c405ac82fde2 ***

runtime/debug: new package
Facilities for printing stack traces from within a running goroutine.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4031041