Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1728)

Issue 4023043: code review 4023043: syscall: attempt to fix windows build, supply missing c... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by adg
Modified:
13 years, 3 months ago
Reviewers:
brainman
CC:
r, rsc1, golang-dev
Visibility:
Public.

Description

syscall: attempt to fix windows build, supply missing constant

Patch Set 1 #

Patch Set 2 : code review 4023043: syscall: attempt to fix windows build, supply missing c... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/pkg/syscall/ztypes_windows_386.go View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4
adg
Hello r, brainman (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 3 months ago (2011-01-20 00:51:31 UTC) #1
rsc1
LGTM
13 years, 3 months ago (2011-01-20 01:31:15 UTC) #2
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=f581c90fada9 *** syscall: attempt to fix windows build, supply missing constant R=r, ...
13 years, 3 months ago (2011-01-20 01:42:09 UTC) #3
brainman
13 years, 3 months ago (2011-01-20 08:20:09 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b