code review 4013045: spec: remove non-blocking channel operators

spec: remove non-blocking channel operators

Add intended changes for close + closed, commented out.

[rsc, 2011-01-27 13:55:06]

Hello golang-dev@googlegroups.com,

I'd like you to review this change.

[rsc, 2011-01-27 14:00:50]

As discussed here: http://goo.gl/OTz4U

[niemeyer, 2011-01-27 19:07:56]

Looks good.

Just some minor suggestions.

http://codereview.appspot.com/4013045/diff/2001/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/4013045/diff/2001/doc/go_spec.html#newcode3073
doc/go_spec.html:3073: because the channel is closed and empty
(<code>false</code>).
Some minor simplification perhaps:

(...)
indicates whether the value received was sent on the
channel (<code>true</code>) or is a
<a href="#The_zero_value">zero value</a> returned
because the channel is closed and empty
(<code>false</code>).

http://codereview.appspot.com/4013045/diff/2001/doc/go_spec.html#newcode4389
doc/go_spec.html:4389: <!-- TODO(rsc): s/.and.closed//g ->
Closing comment tag is missing a dash.

[r, 2011-01-27 19:15:31]

LGTM, agree with niemeyer.

[gri1, 2011-01-27 19:36:23]

FYI.

LGTM otherwise.

http://codereview.appspot.com/4013045/diff/2001/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/4013045/diff/2001/doc/go_spec.html#newcode2
doc/go_spec.html:2: <!-- subtitle Version of January 26, 2011 -->
Please update the date.

http://codereview.appspot.com/4013045/diff/2001/doc/go_spec.html#newcode4402
doc/go_spec.html:4402: simultaneously receives a value and indicates whether it
is a sent value
this sounds like the indication is done through some (not further specified)
different mechanism, but it's just another (2nd) value.

... simultaneously receives channel element and a boolean value; with the
boolean indicating whether...

(or something along those lines). As it is, I had to read it several times as it
confused me.

[rsc, 2011-01-27 19:41:33]

I changed the part gri pointed out to

  The multi-valued <a href="#Communication_operators">receive operation</a>
  returns a received value along with an indication of whether the
channel is closed.

and the part niemeyer pointed out to

  The boolean variable <code>ok</code> indicates whether
  the received value was sent on the channel (<code>true</code>)
  or is a <a href="#The_zero_value">zero value</a> returned
  because the channel is closed and empty (<code>false</code>).

Both are still commented out.

Russ

[gri1, 2011-01-27 19:48:13]

LGTM

On Thu, Jan 27, 2011 at 11:41 AM, Russ Cox <rsc@golang.org> wrote:

> I changed the part gri pointed out to
>
>  The multi-valued <a href="#Communication_operators">receive operation</a>
>   returns a received value along with an indication of whether the
> channel is closed.
>
> and the part niemeyer pointed out to
>
>  The boolean variable <code>ok</code> indicates whether
>   the received value was sent on the channel (<code>true</code>)
>   or is a <a href="#The_zero_value">zero value</a> returned
>  because the channel is closed and empty (<code>false</code>).
>
> Both are still commented out.
>
> Russ
>

[rsc, 2011-01-27 20:34:31]

*** Submitted as 53eb0fc9b87f ***

spec: remove non-blocking channel operators

Add intended changes for close + closed, commented out.

R=golang-dev, niemeyer, r, gri1
CC=golang-dev
http://codereview.appspot.com/4013045