Issue 4008046: code review 4008046: test/chan/doubleselect: fix various races

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4008046: code review 4008046: test/chan/doubleselect: fix various races (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by rsc

Modified:
14 years, 2 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

test/chan/doubleselect: fix various races There were duplicate closes and missing closes, with the result that the program was rarely testing as much as it seemed to be. Now it finishes.

Patch Set 2 : code review 4008046: test/chan/doubleselect: fix various races #

Total comments: 1

Patch Set 3 : code review 4008046: test/chan/doubleselect: fix various races #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -17 lines)			Patch
	M	test/chan/doubleselect.go	View	1 2	3 chunks	+19 lines, -17 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 2 months ago (2011-01-21 16:51:31 UTC) #1

LGTM http://codereview.appspot.com/4008046/diff/2001/test/chan/doubleselect.go File test/chan/doubleselect.go (right): http://codereview.appspot.com/4008046/diff/2001/test/chan/doubleselect.go#newcode83 test/chan/doubleselect.go:83: // end up panicing with: "throw: bad g->status ...

14 years, 2 months ago (2011-01-21 19:53:38 UTC) #2

rsc

14 years, 2 months ago (2011-01-21 20:06:50 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=4a26247db45d ***

test/chan/doubleselect: fix various races

There were duplicate closes and missing closes,
with the result that the program was rarely testing
as much as it seemed to be.  Now it finishes.

R=r
CC=golang-dev
http://codereview.appspot.com/4008046

Expand All Messages | Collapse All Messages