Issue 4004045: code review 4004045: gc: special case code for single-op blocking and non-bl...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4004045: code review 4004045: gc: special case code for single-op blocking and non-bl... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by rsc

Modified:
14 years, 1 month ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

gc: special case code for single-op blocking and non-blocking selects

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+313 lines, -72 lines)			Patch
M	src/cmd/gc/builtin.c.boot	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/gc/print.c	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/runtime.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/gc/select.c	View	1	5 chunks	+172 lines, -45 lines	0 comments	Download
M	src/cmd/gc/sinit.c	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View		10 chunks	+41 lines, -14 lines	0 comments	Download
M	src/pkg/runtime/chan.c	View		11 chunks	+91 lines, -13 lines	0 comments	Download

Total messages: 3

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 1 month ago (2011-01-30 21:07:55 UTC) #1

rsc

*** Submitted as 9fb9bfaf41fd *** gc: special case code for single-op blocking and non-blocking selects ...

14 years, 1 month ago (2011-01-30 21:08:03 UTC) #2

lgtm