code review 3991043: delete float, complex - code changes

delete float, complex - code changes
also:
	cmplx -> complex
	float64(1.0) -> 1.0
	float64(1) -> 1.0

[rsc, 2011-01-19 03:45:37]

Hello gri, r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2011-01-19 03:58:53]

I was surprised at how few opportunities there were
to replace float64(1) or float64(1.0) with 1.0.

Russ

[gri1, 2011-01-19 04:25:26]

LGTM
An improvement, overall, I think.

http://codereview.appspot.com/3991043/diff/9001/test/cmplx.go
File test/cmplx.go (right):

http://codereview.appspot.com/3991043/diff/9001/test/cmplx.go#newcode23
test/cmplx.go:23: _ = complex(f32, f64) // ERROR "cmplx"
ERROR "complex" ?

http://codereview.appspot.com/3991043/diff/9001/test/cmplx.go#newcode24
test/cmplx.go:24: _ = complex(f64, f32) // ERROR "cmplx"
same here?

[r, 2011-01-19 19:42:08]

other than fmt, LGTM

http://codereview.appspot.com/3991043/diff/9001/src/pkg/fmt/fmt_test.go
File src/pkg/fmt/fmt_test.go (right):

http://codereview.appspot.com/3991043/diff/9001/src/pkg/fmt/fmt_test.go#newco...
src/pkg/fmt/fmt_test.go:233: {"%f", float64(-1e-9), "-0.000000"},
you don't need this conversion, and the previous one you could write -7.0
there are more of these below

http://codereview.appspot.com/3991043/diff/9001/src/pkg/fmt/print.go
File src/pkg/fmt/print.go (right):

http://codereview.appspot.com/3991043/diff/9001/src/pkg/fmt/print.go#newcode640
src/pkg/fmt/print.go:640: case *reflect.FloatValue:
this is wrong

http://codereview.appspot.com/3991043/diff/9001/src/pkg/fmt/print.go#newcode646
src/pkg/fmt/print.go:646: case *reflect.ComplexValue:
this is wrong

[rsc, 2011-01-20 03:19:20]

>
http://codereview.appspot.com/3991043/diff/9001/src/pkg/fmt/fmt_test.go#newco...
> src/pkg/fmt/fmt_test.go:233: {"%f", float64(-1e-9), "-0.000000"},
> you don't need this conversion, and the previous one you could write
> -7.0
> there are more of these below

no idea how these slipped through.
somehow that was the only file missed.

X
,s/float64\(([\-+]?(([0-9]*\.[0-9]+|[0-9]+\.[0-9]*)([eE][\-+][0-9]+)?|[0-9]+[eE][\-+][0-9]+))\)/\1/g
X/'/w
src/pkg/fmt/fmt_test.go: #17062
X ,s/float64\(([\-+]?[0-9]+)\)/\1.0/g
X/'/w
src/pkg/fmt/fmt_test.go: #17027

>
http://codereview.appspot.com/3991043/diff/9001/src/pkg/fmt/print.go#newcode640
> src/pkg/fmt/print.go:640: case *reflect.FloatValue:
> this is wrong
>
>
http://codereview.appspot.com/3991043/diff/9001/src/pkg/fmt/print.go#newcode646
> src/pkg/fmt/print.go:646: case *reflect.ComplexValue:
> this is wrong

i think they are correct.  remember that *reflect.FloatValue
is what you get for float32 and float64, and you can use Kind()
or, in this case, Size() to distinguish them.

russ

[rsc, 2011-01-20 03:30:48]

Hello gri, r, gri1 (cc: golang-dev@googlegroups.com),

Please take another look.

[r2, 2011-01-20 04:04:38]

On Jan 19, 2011, at 7:19 PM, Russ Cox wrote:

>>
http://codereview.appspot.com/3991043/diff/9001/src/pkg/fmt/fmt_test.go#newco...
>> src/pkg/fmt/fmt_test.go:233: {"%f", float64(-1e-9), "-0.000000"},
>> you don't need this conversion, and the previous one you could write
>> -7.0
>> there are more of these below
> 
> no idea how these slipped through.
> somehow that was the only file missed.
> 
> X
,s/float64\(([\-+]?(([0-9]*\.[0-9]+|[0-9]+\.[0-9]*)([eE][\-+][0-9]+)?|[0-9]+[eE][\-+][0-9]+))\)/\1/g
> X/'/w
> src/pkg/fmt/fmt_test.go: #17062
> X ,s/float64\(([\-+]?[0-9]+)\)/\1.0/g
> X/'/w
> src/pkg/fmt/fmt_test.go: #17027
> 
>>
http://codereview.appspot.com/3991043/diff/9001/src/pkg/fmt/print.go#newcode640
>> src/pkg/fmt/print.go:640: case *reflect.FloatValue:
>> this is wrong
>> 
>>
http://codereview.appspot.com/3991043/diff/9001/src/pkg/fmt/print.go#newcode646
>> src/pkg/fmt/print.go:646: case *reflect.ComplexValue:
>> this is wrong
> 
> i think they are correct.  remember that *reflect.FloatValue
> is what you get for float32 and float64, and you can use Kind()
> or, in this case, Size() to distinguish them.

oh yes, got it.

LGTM

[rsc, 2011-01-20 04:09:04]

*** Submitted as 95f644f3442f ***

delete float, complex - code changes
also:
	cmplx -> complex
	float64(1.0) -> 1.0
	float64(1) -> 1.0

R=gri, r, gri1, r2
CC=golang-dev
http://codereview.appspot.com/3991043