Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(108)

Issue 3989052: code review 3989052: crypto/openpgp: add package. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by agl1
Modified:
13 years, 1 month ago
Reviewers:
CC:
bradfitz, golang-dev
Visibility:
Public.

Description

crypto/openpgp: add package

Patch Set 1 #

Patch Set 2 : code review 3989052: crypto/openpgp: API pre-review #

Patch Set 3 : code review 3989052: crypto/openpgp: API pre-review #

Total comments: 23

Patch Set 4 : diff -r acf4d0a7130f https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 5 : diff -r a2846f4a9040 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r a2846f4a9040 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1187 lines, -3 lines) Patch
M src/pkg/Makefile View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
A src/pkg/crypto/openpgp/Makefile View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
A src/pkg/crypto/openpgp/canonical_text.go View 1 2 3 1 chunk +58 lines, -0 lines 0 comments Download
A src/pkg/crypto/openpgp/canonical_text_test.go View 1 2 3 4 1 chunk +50 lines, -0 lines 0 comments Download
A src/pkg/crypto/openpgp/keys.go View 1 2 3 4 1 chunk +280 lines, -0 lines 0 comments Download
M src/pkg/crypto/openpgp/packet/packet.go View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/crypto/openpgp/packet/public_key.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A src/pkg/crypto/openpgp/read.go View 1 2 3 1 chunk +413 lines, -0 lines 0 comments Download
A src/pkg/crypto/openpgp/read_test.go View 1 2 3 1 chunk +237 lines, -0 lines 0 comments Download
A src/pkg/crypto/openpgp/write.go View 1 2 3 1 chunk +92 lines, -0 lines 0 comments Download
A src/pkg/crypto/openpgp/write_test.go View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 10
agl1
Hello bradfitzgo (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 2 months ago (2011-01-30 21:17:20 UTC) #1
rsc
api notes http://codereview.appspot.com/3989052/diff/4001/src/pkg/crypto/openpgp/canonical_text.go File src/pkg/crypto/openpgp/canonical_text.go (right): http://codereview.appspot.com/3989052/diff/4001/src/pkg/crypto/openpgp/canonical_text.go#newcode12 src/pkg/crypto/openpgp/canonical_text.go:12: // NewCanonicalTextHash returns a hash which wraps ...
13 years, 2 months ago (2011-01-30 22:21:03 UTC) #2
bradfitz
http://codereview.appspot.com/3989052/diff/4001/src/pkg/crypto/openpgp/keys.go File src/pkg/crypto/openpgp/keys.go (right): http://codereview.appspot.com/3989052/diff/4001/src/pkg/crypto/openpgp/keys.go#newcode52 src/pkg/crypto/openpgp/keys.go:52: type KeyRing struct { could you make this into ...
13 years, 1 month ago (2011-01-31 20:36:16 UTC) #3
agl1
On Mon, Jan 31, 2011 at 3:36 PM, <bradfitz@golang.org> wrote: > http://codereview.appspot.com/3989052/diff/4001/src/pkg/crypto/openpgp/keys.go#newcode52 > src/pkg/crypto/openpgp/keys.go:52: type ...
13 years, 1 month ago (2011-01-31 21:01:38 UTC) #4
bradfitzgoog
On Mon, Jan 31, 2011 at 1:01 PM, Adam Langley <agl@golang.org> wrote: > On Mon, ...
13 years, 1 month ago (2011-01-31 21:43:54 UTC) #5
rsc
If you're deciding between a signature verifier giving the error on the final read instead ...
13 years, 1 month ago (2011-01-31 23:55:40 UTC) #6
rsc
> I'm pretty sure I have used that pattern elsewhere, > but I do not ...
13 years, 1 month ago (2011-01-31 23:58:48 UTC) #7
agl1
http://codereview.appspot.com/3989052/diff/4001/src/pkg/crypto/openpgp/canonical_text.go File src/pkg/crypto/openpgp/canonical_text.go (right): http://codereview.appspot.com/3989052/diff/4001/src/pkg/crypto/openpgp/canonical_text.go#newcode12 src/pkg/crypto/openpgp/canonical_text.go:12: // NewCanonicalTextHash returns a hash which wraps another while ...
13 years, 1 month ago (2011-02-14 17:37:07 UTC) #8
bradfitz
LGTM I haven't ported Camlistore to this yet (which was my original plan before I ...
13 years, 1 month ago (2011-02-23 16:34:30 UTC) #9
agl1
13 years, 1 month ago (2011-02-25 01:20:04 UTC) #10
*** Submitted as http://code.google.com/p/go/source/detail?r=9c3f4b89fcff ***

crypto/openpgp: add package

R=bradfitzgo
CC=golang-dev
http://codereview.appspot.com/3989052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b