code review 3978043: net: Fix race condition in test.

net: Fix race condition in test.

The test code used to do this:

for _, tc := range tests {
	ch <- &tc
}

Note that &tc is always the same value here.  As the value is
received from the channel, the sender can loop around and
change the contents of tc.  This means that the receiver's
value is unstable and can change while it is in use.

[iant, 2011-01-21 20:47:55]

Hello adg (cc: golang-dev@googlegroups.com, chris@cjones.org),

I'd like you to review this change.

[r2, 2011-01-21 21:45:01]

LGTM

[rsc, 2011-01-21 21:55:44]

LGTM

[iant, 2011-01-21 21:57:57]

*** Submitted as http://code.google.com/p/go/source/detail?r=67b7e16100e3 ***

net: Fix race condition in test.

The test code used to do this:

for _, tc := range tests {
	ch <- &tc
}

Note that &tc is always the same value here.  As the value is
received from the channel, the sender can loop around and
change the contents of tc.  This means that the receiver's
value is unstable and can change while it is in use.

R=adg, r2, rsc
CC=chris, golang-dev
http://codereview.appspot.com/3978043

[chris_cjones.org, 2011-01-22 17:28:25]

LGTM

Thanks for fixing my bug.