code review 3973050: ebnflint: exit with non-zero status on error

ebnflint: exit with non-zero status on error

Tweak spec to avoid ebnflint complaints.

[rsc, 2011-01-31 20:11:07]

Hello gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[gri, 2011-01-31 20:57:24]

LGTM

On Mon, Jan 31, 2011 at 12:11 PM, <rsc@golang.org> wrote:

> Reviewers: gri,
>
> Message:
> Hello gri (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> ebnflint: exit with non-zero status on error
>
> Tweak spec to avoid ebnflint complaints.
>
> Please review this at http://codereview.appspot.com/3973050/
>
> Affected files:
>  M doc/go_spec.html
>  M src/cmd/ebnflint/ebnflint.go
>
>
> Index: doc/go_spec.html
> ===================================================================
> --- a/doc/go_spec.html
> +++ b/doc/go_spec.html
> @@ -4078,11 +4078,11 @@
>  CommClause = CommCase ":" { Statement ";" } .
>  CommCase = "case" ( SendExpr | RecvExpr) | "default" .
>  SendExpr =  Expression "&lt;-" Expression .
> +RecvExpr =  [ Expression ( "=" | ":=" ) ] "&lt;-" Expression .
> +</pre>
>  <!-- TODO(rsc):
>  RecvExpr =  [ Expression [ "," Expression ] ( "=" | ":=" ) ] "&lt;-"
> Expression .
>  -->
> -RecvExpr =  [ Expression ( "=" | ":=" ) ] "&lt;-" Expression .
> -</pre>
>
>  <p>
>  For all the send and receive expressions in the "select"
> Index: src/cmd/ebnflint/ebnflint.go
> ===================================================================
> --- a/src/cmd/ebnflint/ebnflint.go
> +++ b/src/cmd/ebnflint/ebnflint.go
> @@ -88,6 +88,7 @@
>        src, err := ioutil.ReadFile(filename)
>        if err != nil {
>                scanner.PrintError(os.Stderr, err)
> +               os.Exit(1)
>        }
>
>        if path.Ext(filename) == ".html" {
> @@ -97,9 +98,11 @@
>        grammar, err := ebnf.Parse(fset, filename, src)
>        if err != nil {
>                scanner.PrintError(os.Stderr, err)
> +               os.Exit(1)
>        }
>
>        if err = ebnf.Verify(fset, grammar, *start); err != nil {
>                scanner.PrintError(os.Stderr, err)
> +               os.Exit(1)
>        }
>  }
>
>
>

[rsc, 2011-01-31 22:42:13]

*** Submitted as http://code.google.com/p/go/source/detail?r=c41bd9d241c7 ***

ebnflint: exit with non-zero status on error

Tweak spec to avoid ebnflint complaints.

R=gri
CC=golang-dev
http://codereview.appspot.com/3973050