code review 3971041: godoc: peephole optimization for generated HTML

godoc: peephole optimization for generated HTML

When searching for regular expressions such as
".", there are many consecutive matches.
In the generated HTML, combine them instead of
generating a new <span> for each adjacent text
segment highlighting a match.

Massively reduces the size of the generated
HTML in those cases.

[gri, 2011-01-13 00:58:43]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2011-01-13 18:16:39]

LGTM

[gri, 2011-01-13 18:23:49]

*** Submitted as http://code.google.com/p/go/source/detail?r=c68ede6c8e86 ***

godoc: peephole optimization for generated HTML

When searching for regular expressions such as
".", there are many consecutive matches.
In the generated HTML, combine them instead of
generating a new <span> for each adjacent text
segment highlighting a match.

Massively reduces the size of the generated
HTML in those cases.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/3971041

Committer: Robert Griesemer <gri@golang.org>

[r, 2011-01-13 18:24:30]

LGTM

http://codereview.appspot.com/3971041/diff/3001/src/cmd/godoc/format.go
File src/cmd/godoc/format.go (right):

http://codereview.appspot.com/3971041/diff/3001/src/cmd/godoc/format.go#newco...
src/cmd/godoc/format.go:96: // the last segment is not adjacent or
s/adjacent/adjacent to/

[gri, 2011-01-13 18:26:09]

will fix in next CL
- gri

On Thu, Jan 13, 2011 at 10:24 AM, <r@golang.org> wrote:

> LGTM
>
>
> http://codereview.appspot.com/3971041/diff/3001/src/cmd/godoc/format.go
> File src/cmd/godoc/format.go (right):
>
>
>
http://codereview.appspot.com/3971041/diff/3001/src/cmd/godoc/format.go#newco...
> src/cmd/godoc/format.go:96: // the last segment is not adjacent or
> s/adjacent/adjacent to/
>
> http://codereview.appspot.com/3971041/
>