Issue 3959041: code review 3959041: gob: make (en|dec)code(Ui|i)nt methods rather than func...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3959041: code review 3959041: gob: make (en|dec)code(Ui|i)nt methods rather than func... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by r

Modified:
14 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gob: make (en|dec)code(Ui|I)nt methods rather than functions. No functional (ha!) change.

Patch Set 1 #

Patch Set 2 : code review 3959041: gob: make (en|dec)code(Ui|I)nt methods rather than func... #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -92 lines)			Patch
M	src/pkg/gob/codec_test.go	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/gob/debug.go	View	8 chunks	+14 lines, -14 lines	0 comments	Download
M	src/pkg/gob/decode.go	View	27 chunks	+33 lines, -33 lines	0 comments	Download
M	src/pkg/gob/decoder.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/gob/encode.go	View	28 chunks	+34 lines, -34 lines	0 comments	Download
M	src/pkg/gob/encoder.go	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 2 months ago (2011-01-12 01:23:26 UTC) #1

rsc

LGTM In description s/Ui|i/Ui|I/ On Tue, Jan 11, 2011 at 20:23, <r@golang.org> wrote: > Reviewers: ...

14 years, 2 months ago (2011-01-12 01:53:57 UTC) #2

14 years, 2 months ago (2011-01-12 01:56:47 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=c8e83c7c8be1 ***

gob: make (en|dec)code(Ui|I)nt methods rather than functions.
No functional (ha!) change.

R=rsc
CC=golang-dev
http://codereview.appspot.com/3959041

Expand All Messages | Collapse All Messages