Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(452)

Issue 3956042: code review 3956042: hg: add cgo/_cgo_* to .hgignore. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by nigeltao
Modified:
14 years, 2 months ago
Reviewers:
CC:
rsc, nigeltao_gnome, golang-dev
Visibility:
Public.

Description

hg: add cgo/_cgo_* to .hgignore.

Patch Set 1 #

Patch Set 2 : code review 3956042: hg: add cgo/_cgo_* to .hgignore. #

Patch Set 3 : code review 3956042: hg: add cgo/_cgo_* to .hgignore. #

Patch Set 4 : code review 3956042: hg: add cgo/_cgo_* to .hgignore. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .hgignore View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
nigeltao
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 2 months ago (2011-01-12 01:06:10 UTC) #1
rsc
Seems like those should be wildcards for any directory, not just runtime/cgo. No? Russ
14 years, 2 months ago (2011-01-12 01:22:21 UTC) #2
nigeltao_gnome
On 12 January 2011 12:22, Russ Cox <rsc@golang.org> wrote: > Seems like those should be ...
14 years, 2 months ago (2011-01-12 02:49:42 UTC) #3
rsc
LGTM
14 years, 2 months ago (2011-01-12 04:06:40 UTC) #4
nigeltao
14 years, 2 months ago (2011-01-12 05:18:00 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=337e8a47dde2 ***

hg: add cgo/_cgo_* to .hgignore.

R=rsc, nigeltao_gnome
CC=golang-dev
http://codereview.appspot.com/3956042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b