code review 3952041: json: do not Marshal unexported struct fields

json: do not Marshal unexported struct fields

[adg, 2011-01-11 05:17:49]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[cw, 2011-01-11 05:28:30]

Then it's behavior differs from that of gobs.

[niemeyer, 2011-01-11 05:31:08]

http://codereview.appspot.com/3952041/diff/1/src/pkg/json/encode.go
File src/pkg/json/encode.go (right):

http://codereview.appspot.com/3952041/diff/1/src/pkg/json/encode.go#newcode227
src/pkg/json/encode.go:227: continue
You may want to use f.PkgPath != "" here, as commonly done elsewhere (including
the json and reflect packages).

Looks good otherwise.

[adg, 2011-01-11 05:32:18]

On 11 January 2011 16:28,  <cw@f00f.org> wrote:
> Then it's behavior differs from that of gobs.

It already does, in that you can't Unmarshal into an unexported field.

[adg, 2011-01-11 05:36:35]

http://codereview.appspot.com/3952041/diff/1/src/pkg/json/encode.go
File src/pkg/json/encode.go (right):

http://codereview.appspot.com/3952041/diff/1/src/pkg/json/encode.go#newcode227
src/pkg/json/encode.go:227: continue
On 2011/01/11 05:31:09, niemeyer wrote:
> You may want to use f.PkgPath != "" here, as commonly done elsewhere
(including
> the json and reflect packages).

Good catch, thanks.

[cw, 2011-01-11 05:37:50]

> It already does, in that you can't Unmarshal into an unexported field.

True.  I was suggesting me make it works like gobs currently do.

[rsc, 2011-01-11 16:09:23]

not sure about this; see also issue 1263

[adg, 2011-01-12 00:49:20]

Given the gob and template CLs, are we moving forward with this?

On 12 January 2011 03:09, Russ Cox <rsc@golang.org> wrote:
> not sure about this; see also issue 1263
>

[r2, 2011-01-12 00:52:54]

On Jan 11, 2011, at 4:48 PM, Andrew Gerrand wrote:

> Given the gob and template CLs, are we moving forward with this?

yes

[rsc1, 2011-01-12 00:53:08]

LGTM

[adg, 2011-01-12 00:59:39]

*** Submitted as http://code.google.com/p/go/source/detail?r=5199c9ed7472 ***

json: do not Marshal unexported struct fields

R=r, cw, niemeyer, rsc
CC=golang-dev
http://codereview.appspot.com/3952041