Issue 3920042: code review 3920042: ld: Fix exported dynamic symbols on Mach-O.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3920042: code review 3920042: ld: Fix exported dynamic symbols on Mach-O. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by iant

Modified:
14 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

ld: Fix exported dynamic symbols on Mach-O. * Avoid confusion between imported and exported symbols. * Record number of imported and exported symbols correctly. * Explictly relocate SMACHOSYM section, since it is not in datap.

Patch Set 1 #

Patch Set 2 : code review 3920042: ld: Fix exported dynamic symbols on Mach-O. #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -21 lines)			Patch
M	src/cmd/6l/asm.c	View	8 chunks	+10 lines, -10 lines	0 comments	Download
M	src/cmd/ld/go.c	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/ld/lib.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/cmd/ld/macho.c	View	3 chunks	+4 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 2 months ago (2011-01-11 21:38:59 UTC) #1

iant

14 years, 2 months ago (2011-01-11 21:56:49 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=24175ef04019 ***

ld: Fix exported dynamic symbols on Mach-O.

* Avoid confusion between imported and exported symbols.
* Record number of imported and exported symbols correctly.
* Explictly relocate SMACHOSYM section, since it is not in datap.

R=rsc
CC=golang-dev
http://codereview.appspot.com/3920042

Expand All Messages | Collapse All Messages