code review 391041: template: add ParseFile and associated tests

template: add ParseFile, MustParseFile, and associated tests

[adg, 2010-03-10 06:05:07]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r2, 2010-03-10 06:48:45]

ParseFile needs a doc comment.

you probably wantt MustParseFile too.

i'm not too happy about little helpers like this in general but i can be talked
into these.

-rob

[adg, 2010-03-10 07:32:31]

Hello r (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2010-03-10 08:09:44]

LGTM after comment and variable name fixes.

http://codereview.appspot.com/391041/diff/7001/8001
File src/pkg/template/template.go (right):

http://codereview.appspot.com/391041/diff/7001/8001#newcode969
src/pkg/template/template.go:969: // ParseFile creates a Template with default
parameters (such as {} for
ParseFile is a wrapper function that creates...

http://codereview.appspot.com/391041/diff/7001/8001#newcode970
src/pkg/template/template.go:970: // metacharacters).  The string fn is the
filename of a file containing
fn is a poor name. change it to filename then

The filename identifies a file containing...

http://codereview.appspot.com/391041/diff/7001/8001#newcode971
src/pkg/template/template.go:971: // the template text while the formatter map
fmap, which may be nil,
s/while/, while/

[adg, 2010-03-10 09:19:27]

*** Submitted as http://code.google.com/p/go/source/detail?r=2dc7f4773836 ***

template: add ParseFile, MustParseFile, and associated tests

R=r
CC=golang-dev
http://codereview.appspot.com/391041