code review 3906041: allows cgo to handle 'float complex' and 'double comple...

allows cgo to handle 'float complex' and 'double complex' types.
adds unit tests for 'float complex', 'double complex' and 'long double
 complex'

note: 'long double complex' can not be used in cgo b/c there is no
      complex256 nor float128 (golang) type.

note: you might want to just discard the .elf and .macho files as they
      have some of my test-systems paths...

[binet, 2011-01-07 18:16:25]

Hello golang-dev@googlegroups.com (cc: binet@cern.ch,
golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2011-01-07 21:18:15]

The names C.complex64 and C.complex128
are in contrast to C.float and C.double.
They should probably be C.complexfloat and C.complexdouble.

Russ

[binet, 2011-01-07 22:02:35]

On 2011/01/07 21:18:15, rsc wrote:
> The names C.complex64 and C.complex128
> are in contrast to C.float and C.double.
> They should probably be C.complexfloat and C.complexdouble.
ah! good suggestion :)
I must say I was finding these (my) names a bit confusing when writing some
CBLAS wrapping code...
with yours, it does read better.

I'll push something along these lines tomorrow.

cheers,
sebastien.

[binet, 2011-01-07 23:36:35]

Hello golang-dev@googlegroups.com, rsc (cc: binet@cern.ch,
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-01-19 18:41:02]

LGTM

Thanks.

[rsc, 2011-01-19 19:30:59]

*** Submitted as 033fe03b47f9 ***

cgo: add complex float, complex double

R=rsc
CC=binet, golang-dev
http://codereview.appspot.com/3906041

Committer: Russ Cox <rsc@golang.org>