code review 3901043: log: add methods for exit and panic

log: add methods for exit and panic
There were already functions for the standard logger;
this just completes the set.

[r, 2011-01-11 04:22:03]

Hello rsc, adg (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[adg, 2011-01-11 05:22:54]

LGTM

Though it would seem nicer if each helper Foo just called std.Foo,
instead of duplicating their contents.

On 11 January 2011 15:22,  <r@golang.org> wrote:
> Reviewers: rsc, adg,
>
> Message:
> Hello rsc, adg (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> log: add methods for exit and panic
> There were already functions for the standard logger;
> this just completes the set.
>
> Please review this at http://codereview.appspot.com/3901043/
>
> Affected files:
>  M src/pkg/log/log.go
>
>
> Index: src/pkg/log/log.go
> ===================================================================
> --- a/src/pkg/log/log.go
> +++ b/src/pkg/log/log.go
> @@ -164,6 +164,45 @@
>  // Arguments are handled in the manner of fmt.Println.
>  func (l *Logger) Println(v ...interface{}) { l.Output(2,
> fmt.Sprintln(v...)) }
>
> +// Exit is equivalent to l.Print() followed by a call to os.Exit(1).
> +func (l *Logger) Exit(v ...interface{}) {
> +       l.Output(2, fmt.Sprint(v...))
> +       os.Exit(1)
> +}
> +
> +// Exitf is equivalent to l.Printf() followed by a call to os.Exit(1).
> +func (l *Logger) Exitf(format string, v ...interface{}) {
> +       l.Output(2, fmt.Sprintf(format, v...))
> +       os.Exit(1)
> +}
> +
> +// Exitln is equivalent to l.Println() followed by a call to os.Exit(1).
> +func (l *Logger) Exitln(v ...interface{}) {
> +       l.Output(2, fmt.Sprintln(v...))
> +       os.Exit(1)
> +}
> +
> +// Panic is equivalent to l.Print() followed by a call to panic().
> +func (l *Logger) Panic(v ...interface{}) {
> +       s := fmt.Sprint(v...)
> +       l.Output(2, s)
> +       panic(s)
> +}
> +
> +// Panicf is equivalent to l.Printf() followed by a call to panic().
> +func (l *Logger) Panicf(format string, v ...interface{}) {
> +       s := fmt.Sprintf(format, v...)
> +       l.Output(2, s)
> +       panic(s)
> +}
> +
> +// Panicln is equivalent to l.Println() followed by a call to panic().
> +func (l *Logger) Panicln(v ...interface{}) {
> +       s := fmt.Sprintln(v...)
> +       l.Output(2, s)
> +       panic(s)
> +}
> +
>  // SetOutput sets the output destination for the standard logger.
>  func SetOutput(w io.Writer) {
>        std.out = w
>
>
>

[r, 2011-01-11 07:10:04]

i considered that, but then the stack counter needs adjustment. this
way they're all at the same level.

i'll let rsc decide.

-rob

[rsc, 2011-01-11 16:21:58]

LGTM

I agree with Rob that they should be separate,
so that the stack traces work out.

[r, 2011-01-11 17:57:51]

*** Submitted as http://code.google.com/p/go/source/detail?r=cfda634d92ff ***

log: add methods for exit and panic
There were already functions for the standard logger;
this just completes the set.

R=rsc, adg
CC=golang-dev
http://codereview.appspot.com/3901043