Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(601)

Issue 3900044: code review 3900044: C&A for Eric Eisner (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by r
Modified:
14 years, 2 months ago
Reviewers:
CC:
gri, golang-dev
Visibility:
Public.

Description

C&A for Eric Eisner there is something funny in the database; trying to recreate the change.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M CONTRIBUTORS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 2 months ago (2011-01-12 05:42:23 UTC) #1
r
*** Submitted as http://code.google.com/p/go/source/detail?r=6a99a705caab *** C&A for Eric Eisner there is something funny in the ...
14 years, 2 months ago (2011-01-12 05:42:26 UTC) #2
gri
14 years, 2 months ago (2011-01-12 05:43:08 UTC) #3
LGTM
- gri

On Tue, Jan 11, 2011 at 9:42 PM, <r@golang.org> wrote:

> Reviewers: gri,
>
> Message:
> Hello gri (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> C&A for Eric Eisner
> there is something funny in the database; trying to recreate the change.
>
> Please review this at http://codereview.appspot.com/3900044/
>
> Affected files:
>  M AUTHORS
>  M CONTRIBUTORS
>
>
> Index: AUTHORS
> ===================================================================
> --- a/AUTHORS
> +++ b/AUTHORS
> @@ -43,6 +43,7 @@
>  Eden Li <eden.li@gmail.com>
>  Eoghan Sherry <ejsherry@gmail.com>
>  Eric Clark <zerohp@gmail.com>
> +Eric Eisner <eric.d.eisner@gmail.com>
>  Evan Shaw <chickencha@gmail.com>
>  Fazlul Shahriar <fshahriar@gmail.com>
>  Firmansyah Adiputra <frm.adiputra@gmail.com>
> Index: CONTRIBUTORS
> ===================================================================
> --- a/CONTRIBUTORS
> +++ b/CONTRIBUTORS
> @@ -78,6 +78,7 @@
>  Eden Li <eden.li@gmail.com>
>  Eoghan Sherry <ejsherry@gmail.com>
>  Eric Clark <zerohp@gmail.com>
> +Eric Eisner <eric.d.eisner@gmail.com>
>  Evan Shaw <chickencha@gmail.com>
>  Fazlul Shahriar <fshahriar@gmail.com>
>  Firmansyah Adiputra <frm.adiputra@gmail.com>
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b