Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(485)

Issue 3885041: code review 3885041: ld: Permit an ELF symbol to be exported in the dynamic ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by iant
Modified:
13 years, 2 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

ld: Permit an ELF symbol to be exported in the dynamic symbol table. This permits exporting crosscall2 from the runtime/cgo package.

Patch Set 1 #

Patch Set 2 : code review 3885041: ld: Permit an ELF symbol to be exported in the dynamic ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/cmd/ld/ldelf.c View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3
iant
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 2 months ago (2011-01-06 23:18:18 UTC) #1
rsc
LGTM
13 years, 2 months ago (2011-01-07 00:24:40 UTC) #2
iant
13 years, 2 months ago (2011-01-07 00:37:16 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=52f5d35515e2 ***

ld: Permit an ELF symbol to be exported in the dynamic symbol table.

This permits exporting crosscall2 from the runtime/cgo
package.

R=rsc
CC=golang-dev
http://codereview.appspot.com/3885041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b