Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(175)

Issue 3849043: code review 3849043: cgo: export unsafe.Pointer as void * (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by niemeyer
Modified:
14 years, 2 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

cgo: export unsafe.Pointer as void * This will enable functions which use unsafe.Pointer as an argument to be correctly exported by cgo.

Patch Set 1 #

Patch Set 2 : code review 3849043: cgo: export unsafe.Pointer as void * #

Patch Set 3 : code review 3849043: cgo: export unsafe.Pointer as void * #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/cmd/cgo/out.go View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
niemeyer
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 2 months ago (2011-01-08 18:44:10 UTC) #1
rsc
The check for import unsafe is a lot of work without being complete. Instead just ...
14 years, 2 months ago (2011-01-11 15:07:58 UTC) #2
niemeyer
> The check for import unsafe is a lot of work without being complete. > ...
14 years, 2 months ago (2011-01-11 15:22:19 UTC) #3
rsc
14 years, 2 months ago (2011-01-11 16:12:11 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=1ec7a4dbdea4 ***

cgo: export unsafe.Pointer as void*

This will enable functions which use unsafe.Pointer as an argument
to be correctly exported by cgo.

R=rsc
CC=golang-dev
http://codereview.appspot.com/3849043

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b