Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 384044: code review 384044: godoc: change -x to -src, update doc.go (missed in prev... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by gri
Modified:
15 years ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

godoc: change -x to -src, update doc.go (missed in previous CL)

Patch Set 1 #

Patch Set 2 : code review 384044: godoc: update doc.go (missed in previous CL) #

Patch Set 3 : code review 384044: godoc: change -x to -src, update doc.go (missed in prev... #

Patch Set 4 : code review 384044: godoc: change -x to -src, update doc.go (missed in prev... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/cmd/godoc/doc.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/godoc/main.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
gri
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years ago (2010-03-10 23:24:58 UTC) #1
gri
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
15 years ago (2010-03-10 23:29:05 UTC) #2
rsc
LGTM
15 years ago (2010-03-10 23:34:12 UTC) #3
rsc
LGTM (but change to -src)
15 years ago (2010-03-10 23:34:13 UTC) #4
gri
15 years ago (2010-03-10 23:41:38 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=f97773e1e4a3 ***

godoc: change -x to -src, update doc.go (missed in previous CL)

R=rsc
CC=golang-dev
http://codereview.appspot.com/384044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b