code review 3834042: net: use closesocket() api instead of CloseHandle() on ...

net: use closesocket api instead of CloseHandle on Windows

thanks to piotrnar for the original CL.
Fixes issue 1371.

[brainman, 2011-01-10 01:03:22]

Hello golang-dev@googlegroups.com,

I'd like you to review this change.

[rsc, 2011-01-11 16:54:37]

LGTM

please drop () from text of CL.
we know they're functions, and
closesocket() is missing an argument.  :-)

[brainman, 2011-01-12 00:33:02]

On 2011/01/11 16:54:37, rsc wrote:
> ..., and
> closesocket() is missing an argument.  :-)

Don't tease me <g>! Where does closesocket() is missing an argument?

Alex

[rsc, 2011-01-12 04:09:48]

On Tue, Jan 11, 2011 at 19:33,  <alex.brainman@gmail.com> wrote:
> On 2011/01/11 16:54:37, rsc wrote:
>>
>> ..., and
>> closesocket() is missing an argument.  :-)
>
> Don't tease me <g>! Where does closesocket() is missing an argument?


the text of the CL is

    net: use closesocket() api instead of CloseHandle() on Windows

my comment was that it should be

    net: use closesocket api instead of CloseHandle on Windows

because we know they're functions and writing
closesocket() is missing an argument anyway.

russ

[brainman, 2011-01-12 04:55:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=b559e0fe1064 ***

net: use closesocket api instead of CloseHandle on Windows

thanks to piotrnar for the original CL.
Fixes issue 1371.

R=rsc
CC=golang-dev
http://codereview.appspot.com/3834042