On Jan 27, 2014 10:25 AM, <bgarcia@golang.org> wrote: > > On 2014/01/27 00:41:20, minux wrote: ...
10 years, 2 months ago
(2014-01-27 23:19:20 UTC)
#9
On Jan 27, 2014 10:25 AM, <bgarcia@golang.org> wrote:
>
> On 2014/01/27 00:41:20, minux wrote:
>>
>> ping?
>
> Ping for who?
for the author of this CL, sorry i didn't make it clear.
I think this CL is really close and i do want this feature.
Sorry for the lack of progress. Actually I got second thoughts and wanted to recheck/reconsider ...
10 years, 2 months ago
(2014-01-28 23:16:41 UTC)
#10
Sorry for the lack of progress. Actually I got second thoughts and wanted
to recheck/reconsider a few things, but became busy with other stuff.
Most importantly, I realized that the template already has srcLink (and
pkgLink) functions. Moreover it is made "overrideable" (by
Presentation.URLForSrc). This suggests that source path links should
probably use that (and also convert package paths). But I haven't been able
to determine the specific intended use of this extension point.
In addition, the structure of the title is currently opaque to the main
template, so without additional information / parameters, it would need
some heuristics to find which parts to convert to links.
One approach could be to treat Title as a template on its own (always, or
just if it contains "{{.*}}"?), add a function/method that gives the parent
directories' paths, and use "range" with "srcLink" and "filename" to
generate the links.
I'll have a bit more time to look at it in the weekend, but if you want it
urgently, feel free to create a separate CL based on this.
On Tue, Jan 28, 2014 at 8:18 AM, minux <minux.ma@gmail.com> wrote:
>
> On Jan 27, 2014 10:25 AM, <bgarcia@golang.org> wrote:
> >
> > On 2014/01/27 00:41:20, minux wrote:
> >>
> >> ping?
> >
> > Ping for who?
> for the author of this CL, sorry i didn't make it clear.
>
> I think this CL is really close and i do want this feature.
>
Sorry again for the delay. I have made some progress but in the meanwhile I ...
10 years, 1 month ago
(2014-02-19 23:43:22 UTC)
#11
Sorry again for the delay.
I have made some progress but in the meanwhile I noticed a (somewhat)
related regression in tip that is already logged as
https://code.google.com/p/go/issues/detail?id=7254 . Although it may not
directly conflict, I'm hesitant to make changes until it is resolved.
Moreover, despite having an owner, it is not shown on
https://go-dev.appspot.com/#all so I'm afraid it might get overlooked.
Unfortunately I have limited time to look into it, but I couldn't find
relevant changes in go.tools, so it seems likely it is triggered by some
change in go/* (go/doc ?).
By the way, does the March feature freeze also apply to go.tools?
On Wed, Jan 29, 2014 at 8:16 AM, speter <speter.go1@gmail.com> wrote:
> Sorry for the lack of progress. Actually I got second thoughts and wanted
> to recheck/reconsider a few things, but became busy with other stuff.
>
> Most importantly, I realized that the template already has srcLink (and
> pkgLink) functions. Moreover it is made "overrideable" (by
> Presentation.URLForSrc). This suggests that source path links should
> probably use that (and also convert package paths). But I haven't been able
> to determine the specific intended use of this extension point.
>
> In addition, the structure of the title is currently opaque to the main
> template, so without additional information / parameters, it would need
> some heuristics to find which parts to convert to links.
>
> One approach could be to treat Title as a template on its own (always, or
> just if it contains "{{.*}}"?), add a function/method that gives the parent
> directories' paths, and use "range" with "srcLink" and "filename" to
> generate the links.
>
> I'll have a bit more time to look at it in the weekend, but if you want it
> urgently, feel free to create a separate CL based on this.
>
>
>
> On Tue, Jan 28, 2014 at 8:18 AM, minux <minux.ma@gmail.com> wrote:
>
>>
>> On Jan 27, 2014 10:25 AM, <bgarcia@golang.org> wrote:
>> >
>> > On 2014/01/27 00:41:20, minux wrote:
>> >>
>> >> ping?
>> >
>> > Ping for who?
>> for the author of this CL, sorry i didn't make it clear.
>>
>> I think this CL is really close and i do want this feature.
>>
>
>
On Wed, Feb 19, 2014 at 3:43 PM, speter <speter.go1@gmail.com> wrote: > > By the ...
10 years, 1 month ago
(2014-02-20 01:31:14 UTC)
#12
On Wed, Feb 19, 2014 at 3:43 PM, speter <speter.go1@gmail.com> wrote:
>
> By the way, does the March feature freeze also apply to go.tools?
We're going to have to freeze those parts of go.tools that become part
of the Go release, like godoc, go cover, and the packages they depend
on. I don't know if the freeze will happen right on March 1.
Ian
R=close To the author of this CL: The Go project has moved to Gerrit Code ...
9 years, 3 months ago
(2014-12-19 05:17:39 UTC)
#13
R=close
To the author of this CL:
The Go project has moved to Gerrit Code Review.
If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.
If there has been discussion on this CL, please give a link to it
(golang.org/cl/38130047 is best) in the description in your
new CL.
Thanks very much.
R=close To the author of this CL: The Go project has moved to Gerrit Code ...
9 years, 3 months ago
(2014-12-19 05:17:39 UTC)
#14
R=close
To the author of this CL:
The Go project has moved to Gerrit Code Review.
If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.
If there has been discussion on this CL, please give a link to it
(golang.org/cl/38130047 is best) in the description in your
new CL.
Thanks very much.
Issue 38130047: code review 38130047: go.tools/godoc: make path elements hyperlinks
Created 10 years, 3 months ago by speter
Modified 9 years, 3 months ago
Reviewers:
Base URL:
Comments: 15