Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(345)

Issue 38130047: code review 38130047: go.tools/godoc: make path elements hyperlinks

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by speter
Modified:
9 years, 3 months ago
Reviewers:
CC:
golang-codereviews, gobot, gri, bgarcia, minux1, iant
Visibility:
Public.

Description

go.tools/godoc: make path elements hyperlinks for /src Updates issue 5869.

Patch Set 1 #

Patch Set 2 : diff -r 67a885f1ab24 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 67a885f1ab24 https://code.google.com/p/go.tools #

Total comments: 14

Patch Set 4 : diff -r 87da52c795ad https://code.google.com/p/go.tools #

Total comments: 1

Patch Set 5 : diff -r 87da52c795ad https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -12 lines) Patch
M godoc/godoc.go View 1 2 3 4 2 chunks +18 lines, -2 lines 0 comments Download
M godoc/godoc_test.go View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
M godoc/page.go View 1 2 3 4 3 chunks +13 lines, -0 lines 0 comments Download
M godoc/server.go View 1 2 3 4 3 chunks +5 lines, -2 lines 0 comments Download
M godoc/static/godoc.html View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M godoc/static/static.go View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14
speter
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools
10 years, 3 months ago (2013-12-21 16:28:49 UTC) #1
gobot
R=gri@golang.org (assigned by r@golang.org)
10 years, 3 months ago (2013-12-23 17:57:39 UTC) #2
gri
Some initial feedback. Leaving for Brad Garcia. https://codereview.appspot.com/38130047/diff/20002/godoc/server.go File godoc/server.go (right): https://codereview.appspot.com/38130047/diff/20002/godoc/server.go#newcode422 godoc/server.go:422: names, relpaths ...
10 years, 2 months ago (2014-01-02 19:28:24 UTC) #3
gobot
R=bgarcia@golang.org (assigned by gri@golang.org)
10 years, 2 months ago (2014-01-02 19:28:53 UTC) #4
speter
PTAL https://codereview.appspot.com/38130047/diff/20002/godoc/server.go File godoc/server.go (right): https://codereview.appspot.com/38130047/diff/20002/godoc/server.go#newcode422 godoc/server.go:422: names, relpaths := []string{}, []string{} On 2014/01/02 19:28:24, ...
10 years, 2 months ago (2014-01-03 01:49:56 UTC) #5
bgarcia
Looks pretty good. Instead of adding an additional field to the Page struct, add this ...
10 years, 2 months ago (2014-01-03 16:23:02 UTC) #6
minux1
ping?
10 years, 2 months ago (2014-01-27 00:41:20 UTC) #7
bgarcia
On 2014/01/27 00:41:20, minux wrote: > ping? Ping for who?
10 years, 2 months ago (2014-01-27 15:25:12 UTC) #8
minux1
On Jan 27, 2014 10:25 AM, <bgarcia@golang.org> wrote: > > On 2014/01/27 00:41:20, minux wrote: ...
10 years, 2 months ago (2014-01-27 23:19:20 UTC) #9
speter
Sorry for the lack of progress. Actually I got second thoughts and wanted to recheck/reconsider ...
10 years, 2 months ago (2014-01-28 23:16:41 UTC) #10
speter
Sorry again for the delay. I have made some progress but in the meanwhile I ...
10 years, 1 month ago (2014-02-19 23:43:22 UTC) #11
iant
On Wed, Feb 19, 2014 at 3:43 PM, speter <speter.go1@gmail.com> wrote: > > By the ...
10 years, 1 month ago (2014-02-20 01:31:14 UTC) #12
gobot
R=close To the author of this CL: The Go project has moved to Gerrit Code ...
9 years, 3 months ago (2014-12-19 05:17:39 UTC) #13
gobot
9 years, 3 months ago (2014-12-19 05:17:39 UTC) #14
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/38130047 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b