Issue 3787044: code review 3787044: encoding/binary: reject types with implementation-depen...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3787044: code review 3787044: encoding/binary: reject types with implementation-depen... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by pgavlin

Modified:
13 years, 4 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

encoding/binary: reject types with implementation-dependent sizes Fixes issue 1201.

Patch Set 1 #

Patch Set 2 : code review 3787044: encoding/binary: reject types with implementation-depen... #

Patch Set 3 : code review 3787044: encoding/binary: reject types with implementation-depen... #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -0 lines)			Patch
	M	src/pkg/encoding/binary/binary.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	src/pkg/encoding/binary/binary_test.go	View	1 2	2 chunks	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

pgavlin

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 4 months ago (2011-01-02 02:09:45 UTC) #1

pgavlin

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 4 months ago (2011-01-04 16:22:39 UTC) #3

rsc

13 years, 4 months ago (2011-01-04 18:42:51 UTC) #5

*** Submitted as c0076ac0f367 ***

encoding/binary: reject types with implementation-dependent sizes

Fixes issue 1201.

R=rsc
CC=golang-dev
http://codereview.appspot.com/3787044

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages