code review 3769042: go/ast: provide complete node text range info

go/ast: provide complete node text range info

- add End() method to all nodes; the text range of a node n is [n.Pos(), n.End())
- various small bug fixes in the process
- fixed several comments

[gri, 2010-12-21 22:55:44]

Hello r, rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2011-01-04 17:06:01]

LGTM

http://codereview.appspot.com/3769042/diff/6001/src/pkg/go/ast/ast.go
File src/pkg/go/ast/ast.go (right):

http://codereview.appspot.com/3769042/diff/6001/src/pkg/go/ast/ast.go#newcode375
src/pkg/go/ast/ast.go:375: return x.Ellipsis + 3 // len("...")
x.Ellipsis + len("...")

same below

[gri, 2011-01-04 18:09:38]

On Tue, Jan 4, 2011 at 9:06 AM, <rsc@golang.org> wrote:

>
> src/pkg/go/ast/ast.go:375: return x.Ellipsis + 3 // len("...")
> x.Ellipsis + len("...")
>
> same below


This will require a cast:

x.Ellipsis + token.Token(len("..."))

since len() doesn't return untyped constants (perhaps it should).

I opted for the comment as it seemed cleaner to me.
- gri

[rsc, 2011-01-04 18:13:50]

> This will require a cast:
> x.Ellipsis + token.Token(len("..."))
> since len() doesn't return untyped constants (perhaps it should).

ugh.  okay, fine as is.

[gri, 2011-01-04 18:14:19]

*** Submitted as http://code.google.com/p/go/source/detail?r=16c3b63d642f ***

go/ast: provide complete node text range info

- add End() method to all nodes; the text range of a node n is [n.Pos(),
n.End())
- various small bug fixes in the process
- fixed several comments

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/3769042

Committer: Robert Griesemer <gri@golang.org>