Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Issue 376041: code review 376041: godoc: provide mode which shows exported interface in "... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by gri
Modified:
15 years ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

godoc: provide mode which shows exported interface in "source form" - on the commandline: godoc -x big - in a webpage: provide form parameter ?m=src Known issues: - Positioning of comments incorrect in several cases. Separate CL. - Need a link/menu to switch between different modes of presentation in the web view.

Patch Set 1 #

Patch Set 2 : code review 376041: godoc: provide mode which shows exported interface in "... #

Patch Set 3 : code review 376041: godoc: provide mode which shows exported interface in "... #

Patch Set 4 : code review 376041: godoc: provide mode which shows exported interface in "... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -16 lines) Patch
M lib/godoc/package.html View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/godoc/package.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M src/cmd/godoc/godoc.go View 1 2 7 chunks +24 lines, -12 lines 0 comments Download
M src/cmd/godoc/main.go View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5
gri
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years ago (2010-03-09 23:58:38 UTC) #1
rsc
Some missing newlines / misplaced comments at http://uetli:6666/pkg/math/?m=ast#Ceil You called this "source form"; m=src instead ...
15 years ago (2010-03-10 00:09:25 UTC) #2
gri
Changed from m="ast" to m="src". The comment placement issue is known an in some ways ...
15 years ago (2010-03-10 22:10:06 UTC) #3
rsc
LGTM maybe change the command line flag to --src too?
15 years ago (2010-03-10 22:32:07 UTC) #4
gri
15 years ago (2010-03-10 23:22:27 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=6a339432a45a ***

godoc: provide mode which shows exported interface in "source form"
- on the commandline: godoc -x big
- in a webpage: provide form parameter ?m=src

Known issues:
- Positioning of comments incorrect in several cases. Separate CL.
- Need a link/menu to switch between different modes of presentation
  in the web view.

R=rsc
CC=golang-dev
http://codereview.appspot.com/376041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b