Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(159)

Issue 3708041: code review 3708041: ld: text segment should not be writable (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by rsc
Modified:
13 years, 3 months ago
Reviewers:
CC:
adg, golang-dev
Visibility:
Public.

Description

ld: text segment should not be writable

Patch Set 1 #

Patch Set 2 : code review 3708041: ld: text segment should not be writable #

Patch Set 3 : code review 3708041: ld: text segment should not be writable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/ld/data.c View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 3 months ago (2010-12-16 03:27:38 UTC) #1
adg
LGTM
13 years, 3 months ago (2010-12-16 03:28:55 UTC) #2
rsc
13 years, 3 months ago (2010-12-16 03:29:57 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=bbec9b79e478 ***

ld: text segment should not be writable

R=adg
CC=golang-dev
http://codereview.appspot.com/3708041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b