Issue 3702041: code review 3702041: runtime: move windows goargs implementation from runtim...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3702041: code review 3702041: runtime: move windows goargs implementation from runtim... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by brainman

Modified:
13 years, 4 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: move windows goargs implementation from runtime and into os package

Patch Set 1 #

Patch Set 2 : code review 3702041: runtime: move windows goargs implementation from runtim... #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -123 lines)			Patch
M	src/pkg/os/env_windows.go	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/runtime.c	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/string.goc	View	2 chunks	+0 lines, -30 lines	0 comments	Download
M	src/pkg/runtime/windows/os.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/windows/thread.c	View	2 chunks	+0 lines, -56 lines	0 comments	Download
M	src/pkg/syscall/mksyscall_windows.sh	View	4 chunks	+9 lines, -9 lines	0 comments	Download
M	src/pkg/syscall/syscall_windows.go	View	4 chunks	+26 lines, -23 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_windows_386.go	View	3 chunks	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change.

13 years, 4 months ago (2010-12-15 23:26:38 UTC) #1

brainman

This CL is an alternative to replace http://codereview.appspot.com/3096042/. It solves the same problem, but I ...

13 years, 4 months ago (2010-12-15 23:28:31 UTC) #2

brainman

13 years, 4 months ago (2010-12-16 01:18:27 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=1f3c3696babb ***

runtime: move windows goargs implementation from runtime and into os package

R=rsc
CC=golang-dev
http://codereview.appspot.com/3702041

Committer: Alex Brainman <alex.brainman@gmail.com>

Expand All Messages | Collapse All Messages