code review 36860043: cmd/go: fix cgo error output rewrite

cmd/go: fix cgo error output rewrite
for example, we now rewrite *_Ctype_int to *C.int.
Fixes issue 6781.

[minux1, 2013-12-03 23:23:11]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[minux1, 2013-12-10 04:40:11]

gentoo ping.

[rsc, 2013-12-18 17:48:14]

https://codereview.appspot.com/36860043/diff/60001/src/cmd/go/build.go
File src/cmd/go/build.go (right):

https://codereview.appspot.com/36860043/diff/60001/src/cmd/go/build.go#newcod...
src/cmd/go/build.go:1265: var cgoTypeSigRe = regexp.MustCompile(`type
([*\[0-9\]]*)_Ctype_([^ )]*)`)
what about chan _Ctype_int or func(_Ctype_int)?
it is probably fine to replace `\b_Ctype_\B` with `C.`

[gobot, 2013-12-20 16:26:12]

Replacing golang-dev with golang-codereviews.

[minux1, 2014-01-09 21:51:36]

PTAL.
On 2013/12/18 17:48:14, rsc wrote:
>
https://codereview.appspot.com/36860043/diff/60001/src/cmd/go/build.go#newcod...
> src/cmd/go/build.go:1265: var cgoTypeSigRe = regexp.MustCompile(`type
> ([*\[0-9\]]*)_Ctype_([^ )]*)`)
> what about chan _Ctype_int or func(_Ctype_int)?
> it is probably fine to replace `\b_Ctype_\B` with `C.`
Done.

[minux1, 2014-02-13 08:11:54]

Hello golang-codereviews@googlegroups.com, rsc@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[iant, 2014-02-13 17:33:30]

LGTM

[minux1, 2014-02-13 20:55:28]

*** Submitted as https://code.google.com/p/go/source/detail?r=5c3270d0abf1 ***

cmd/go: fix cgo error output rewrite
for example, we now rewrite *_Ctype_int to *C.int.
Fixes issue 6781.

LGTM=iant
R=golang-codereviews, rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/36860043