code review 36810043: io: add definitions of seeker's whence consts

io: add definitions of seeker's whence consts
Fixes issue 6873.

[minux1, 2013-12-03 22:26:54]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-12-03 22:30:58]

NOT LGTM

We already have these in pkg/os, also with this TERRIBLE_CASE. Let's stop
the bleeding.

In Go 2 we could move them and fix the case or maybe even change the
signature to not be so C-like.
 On Dec 3, 2013 2:26 PM, <minux.ma@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> io: add definitions of seeker's whence consts
> Fixes issue 6873.
>
> Please review this at https://codereview.appspot.com/36810043/
>
> Affected files (+10, -0 lines):
>   M src/pkg/io/io.go
>
>
> Index: src/pkg/io/io.go
> ===================================================================
> --- a/src/pkg/io/io.go
> +++ b/src/pkg/io/io.go
> @@ -101,6 +101,16 @@
>         Seek(offset int64, whence int) (int64, error)
>  }
>
> +// Seek whence values.
> +// These constants used to be defined in the os package only, however,
> +// as the Seeker interface is defined here, all portable users should
> +// use the definition here instead of the ones in the os package.
> +const (
> +       SEEK_SET int = 0 // seek relative to the origin of the file
> +       SEEK_CUR int = 1 // seek relative to the current offset
> +       SEEK_END int = 2 // seek relative to the end
> +)
> +
>  // ReadWriter is the interface that groups the basic Read and Write
> methods.
>  type ReadWriter interface {
>         Reader
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[minux1, 2013-12-03 22:37:45]

On Tue, Dec 3, 2013 at 5:30 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> NOT LGTM
>
> We already have these in pkg/os, also with this TERRIBLE_CASE. Let's stop
> the bleeding.
>
> In Go 2 we could move them and fix the case or maybe even change the
> signature to not be so C-like.
>
No problem. I just wanted the opinion on this matter so that I can set the
status of the corresponding
issue.

Do you want me to file an issue for Go 2? (Probably too early for now)

[bradfitz, 2013-12-03 22:41:01]

Issue is fine.

But I imagine any Go 2 standard library would start with scrapping
everything and then deciding for each item what to bring it and how to
change it.
 On Dec 3, 2013 2:37 PM, "minux" <minux.ma@gmail.com> wrote:

>
> On Tue, Dec 3, 2013 at 5:30 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:
>
>> NOT LGTM
>>
>> We already have these in pkg/os, also with this TERRIBLE_CASE. Let's stop
>> the bleeding.
>>
>> In Go 2 we could move them and fix the case or maybe even change the
>> signature to not be so C-like.
>>
> No problem. I just wanted the opinion on this matter so that I can set the
> status of the corresponding
> issue.
>
> Do you want me to file an issue for Go 2? (Probably too early for now)
>