code review 36800043: os: return io.ShortWrite when Write returns n != len(b)

os: return io.ShortWrite when Write returns n != len(b)
Fixes issue 6855.

[minux1, 2013-12-03 22:19:45]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-12-03 22:24:01]

I would only do this if && e == nil. Don't hide errors that came first.

Otherwise SGTM.
On Dec 3, 2013 2:19 PM, <minux.ma@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> os: return io.ShortWrite when Write returns n != len(b)
> Fixes issue 6855.
>
> Please review this at https://codereview.appspot.com/36800043/
>
> Affected files (+3, -0 lines):
>   M src/pkg/os/file.go
>
>
> Index: src/pkg/os/file.go
> ===================================================================
> --- a/src/pkg/os/file.go
> +++ b/src/pkg/os/file.go
> @@ -140,6 +140,9 @@
>         if n < 0 {
>                 n = 0
>         }
> +       if n != len(b) {
> +               err = io.ErrShortWrite
> +       }
>
>         epipecheck(f, e)
>
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[minux1, 2013-12-03 22:40:34]

On 2013/12/03 22:24:01, bradfitz wrote:
> I would only do this if && e == nil. Don't hide errors that came first.
as you can see from the code below, if e != nil, then err will be
unconditionally re-set.
> Otherwise SGTM.

[bradfitz, 2013-12-03 22:42:34]

LGTM at least

Test I realize would be hard without e.g. fuse.
 On Dec 3, 2013 2:40 PM, <minux.ma@gmail.com> wrote:

> On 2013/12/03 22:24:01, bradfitz wrote:
>
>> I would only do this if && e == nil. Don't hide errors that came
>>
> first.
> as you can see from the code below, if e != nil, then err will be
> unconditionally re-set.
>
>> Otherwise SGTM.
>>
>
> https://codereview.appspot.com/36800043/
>

[minux1, 2013-12-03 22:48:05]

On Tue, Dec 3, 2013 at 5:42 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> Test I realize would be hard without e.g. fuse.
>
or use root to access ram disks. I can't think of a way to properly test
this without
fuse and root. suggestions welcome.

[iant, 2013-12-03 22:56:50]

LGTM

[minux1, 2013-12-10 04:30:08]

This change is accidentally submitted together with CL 36930044 in rev
51b22afec887.