Issue 36180044: code review 36180044: syscall: add NewCallbackCDecl again

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 36180044: code review 36180044: syscall: add NewCallbackCDecl again (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by brainman

Modified:
10 years, 4 months ago

Reviewers:
rsc

CC:
golang-dev, kin.wilson.za, rsc

Visibility:
Public.

Description

syscall: add NewCallbackCDecl again Fixes issue 6338

Patch Set 1 #

Patch Set 2 : diff -r 07c2b7427352 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 07c2b7427352 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 302c3d2b8c1b https://go.googlecode.com/hg/ #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+212 lines, -7 lines)			Patch
M	src/pkg/runtime/callback_windows.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/runtime/syscall_windows.goc	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/pkg/runtime/syscall_windows_test.go	View	1	2 chunks	+207 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_windows.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 4 months ago (2013-12-11 03:38:46 UTC) #1

kin.wilson.za

Confirmed that patches pass on windows/386 (also verified that the test correctly fails when changing ...

10 years, 4 months ago (2013-12-11 16:15:07 UTC) #2

brainman

On 2013/12/11 16:15:07, kin.wilson.za wrote: > ... but > the thresholds may be slightly different ...

10 years, 4 months ago (2013-12-12 00:09:17 UTC) #3

brainman

10 years, 4 months ago (2013-12-19 03:38:57 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=1702dca49310 ***

syscall: add NewCallbackCDecl again

Fixes issue 6338

R=golang-dev, kin.wilson.za, rsc
CC=golang-dev
https://codereview.appspot.com/36180044

Expand All Messages | Collapse All Messages